From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7DACC43387 for ; Thu, 17 Jan 2019 14:06:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF20A20652 for ; Thu, 17 Jan 2019 14:06:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="PgYavF9E" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726188AbfAQOF7 (ORCPT ); Thu, 17 Jan 2019 09:05:59 -0500 Received: from mail-eopbgr60044.outbound.protection.outlook.com ([40.107.6.44]:11617 "EHLO EUR04-DB3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725878AbfAQOF7 (ORCPT ); Thu, 17 Jan 2019 09:05:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pBnK5ci/V9LsWKRdykF0NeJ8YD4jwZyMrfEKh2M3jmg=; b=PgYavF9ExW6fjJyRqQDLT6DycH0BP0Q6I/foDINbtzHHt+z0FUYrnHubynDWvvufmraqIrZI+LONKq9ZTMeFEoYwbh2CNoMMtWfm9LZjKdc3Uw3NKKr/XIlOkDamHfZ0u8D3r/bJrKGWmgHJRWHHE1Fg43F5oMM296xf+FxanBs= Received: from AM6PR05MB6056.eurprd05.prod.outlook.com (20.179.2.148) by AM6PR05MB4136.eurprd05.prod.outlook.com (52.135.160.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1537.27; Thu, 17 Jan 2019 14:05:53 +0000 Received: from AM6PR05MB6056.eurprd05.prod.outlook.com ([fe80::5490:e4ea:7798:e65f]) by AM6PR05MB6056.eurprd05.prod.outlook.com ([fe80::5490:e4ea:7798:e65f%3]) with mapi id 15.20.1516.019; Thu, 17 Jan 2019 14:05:53 +0000 From: Ido Schimmel To: Florian Fainelli CC: "netdev@vger.kernel.org" , "andrew@lunn.ch" , "vivien.didelot@gmail.com" , "davem@davemloft.net" , Jiri Pirko , "ilias.apalodimas@linaro.org" , "ivan.khoronzhuk@linaro.org" , "roopa@cumulusnetworks.com" , "nikolay@cumulusnetworks.com" Subject: Re: [PATCH net-next 09/14] net: bridge: Propagate MC addresses with VID through switchdev Thread-Topic: [PATCH net-next 09/14] net: bridge: Propagate MC addresses with VID through switchdev Thread-Index: AQHUrdaUXwGax1dog0C13Csnb6Xe3KWzf9SA Date: Thu, 17 Jan 2019 14:05:53 +0000 Message-ID: <20190117140551.GA21505@splinter> References: <20190116200102.2749-1-f.fainelli@gmail.com> <20190116200102.2749-10-f.fainelli@gmail.com> In-Reply-To: <20190116200102.2749-10-f.fainelli@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM5PR0402CA0001.eurprd04.prod.outlook.com (2603:10a6:203:90::11) To AM6PR05MB6056.eurprd05.prod.outlook.com (2603:10a6:20b:ab::20) authentication-results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM6PR05MB4136;6:9ZqW1sPdUWZ9uLWpHQnSweqJfysoQWBsM570rRSvzI2US4HODKmy8MxS7bQtO/t/7wjr6VvxsKmdz21C48z+VLmIWEh119j2f5EJYB5U2TrhtlnsriniPFQr/Ye2aLnT/d5Gdksol0/b2UlhZgjHaoAEhQky2yLfLk3mtZirtAeSxBpOFwIVZ9OGkhNNPFwEsnfD3miAozRiQz7vOBxlJV/e0PjuEtKo3WsIEqz5Qvi1Ta8kdE7GsMXhRbVQWwzG6sUUxWARcYEhusDwlGMlt3iiiI8y3bB0KC2DqGC6sMIUfPcf/W4j1AaAYK1Gk13Q9l3cclD5rPiesS6M7KJODkFn/JnSUh3hJSR9iIjKFpj2TwhzWbyXPIDShpNgLrJEI89yzlmXDRarrSwz55SZTpKU6i/Zs5VhH8P7sQ65QUhtPGCccD0mJgSUM+BZs/Sum0ah9c41QNJvQDmIslaHaA==;5:Uv2gSrYova/wK4K5JUxB9DYyf/e8yzpW2sdGvV0uZFPsEPfuqjLN09t/TeDP2jA62Cp4cnS9M44Rp13OHZqA7fF3mXKi0fhz30GGC/YxOl4c+sF9p7DhMUf44gmWJ9LMEBT2gzZunFdnwYYiWwh/T2cnvpOD/W1X7xUtJbw1RtPdzxjui/2qGxCb4CiZ+sw7mgSGEcvk7Tz31NToVEBvIw==;7:fC6NJwmNeSYNqNmxeJhQDnkgsDB+kfU7Pl/z1Jy2Rumn8gti3/5XCHgmcGNyLnQ7TNgedMupfPbucdnjX7cf4qVWRGe91xjeN4YqB6a1XLjgKnZduClshCnmpXGQhrtZpWOd4Kx5rJHy0oW1xQcwhQ== x-ms-office365-filtering-correlation-id: 923da798-1572-46ef-d021-08d67c84e493 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020);SRVR:AM6PR05MB4136; x-ms-traffictypediagnostic: AM6PR05MB4136: x-microsoft-antispam-prvs: x-forefront-prvs: 0920602B08 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(7916004)(396003)(346002)(136003)(366004)(376002)(39860400002)(199004)(189003)(54906003)(6512007)(9686003)(316002)(66066001)(99286004)(14454004)(7736002)(305945005)(386003)(102836004)(6506007)(76176011)(6436002)(8936002)(52116002)(6486002)(33896004)(26005)(229853002)(8676002)(81156014)(81166006)(105586002)(106356001)(5660300001)(11346002)(446003)(33716001)(6916009)(33656002)(476003)(6116002)(186003)(3846002)(97736004)(256004)(14444005)(86362001)(486006)(2906002)(53936002)(1076003)(68736007)(6246003)(4326008)(25786009)(478600001)(71200400001)(71190400001)(39060400002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM6PR05MB4136;H:AM6PR05MB6056.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: h1CeRGyjH+lweQ5w/7Os24wOFDmb5/zZpSCJ+WItZAi3t0wdp0X7dJwZ7mvnIkhTxs+vFu7pHVbwgQD/WJIT1QnN9o+7UBr9Ut7cT4VfdovI9b8ePDXpLcDhcj4114Cr/Wmm/bd6Y9PJCBlzc7xogOD4AKc/wSQ9weJ3LtSg5SkRzIf6JazespPPWavqaCGveXEGZtsyL+7fmoeFi6kXWVUNSWxrUsCMByyQm4X6bG+rKoJmWUXaaQpfuv175msN495rpmqHi7ESHSsGKkO0q1q/qdHWw66crdrwOq/M5ksItdsMI/4qIds3tGYFo5bqS1WDJ6yWUgynJReqUabkgk6RxnqIuo8MvMZ4KKKNAiqfU5jWCC4fqc1wOEBTBs6UOgOqDuHF78x48tHTGZmYnjA0PKxfhxvQlb9MKYLcVe0= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <6C1C1F27C1ED2641B83EC9A3835E3813@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 923da798-1572-46ef-d021-08d67c84e493 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jan 2019 14:05:52.9962 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB4136 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jan 16, 2019 at 12:00:57PM -0800, Florian Fainelli wrote: > In order for bridge port members to get a chance to implement unicast > and multicast address filtering correctly, which would matter for e.g: > switch network devices, synchronize the UC and MC lists down to the > individual bridge port members using switchdev HOST_MDB objects such > that this does not impact drivers that already have a ndo_set_rx_mode() > operation which likely already operate in promiscuous mode. >=20 > When the bridge has multicast snooping enabled, proper HOST_MDB > notifications will be sent through br_mdb_notify() already. I don't understand the change. HOST_MDB is used to notify underlying drivers about MDB entries that should be configured to locally receive packets. This is triggered by the transmission of an IGMP report through the bridge, for example. It seems that you're trying to overload HOST_MDB with multicast address filtering on bridge ports? Why are you performing this filtering? Shouldn't you allow all MAC addresses to ingress?