From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F7E6C43387 for ; Thu, 17 Jan 2019 14:49:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 593EA20652 for ; Thu, 17 Jan 2019 14:49:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="QcxqPswK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727671AbfAQOtr (ORCPT ); Thu, 17 Jan 2019 09:49:47 -0500 Received: from mail-eopbgr150072.outbound.protection.outlook.com ([40.107.15.72]:44576 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727083AbfAQOtr (ORCPT ); Thu, 17 Jan 2019 09:49:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2AI2NMoNRrNQrpRTpZ4NxHF+eBNU8LsiwqkdYm10rEc=; b=QcxqPswKODeW3X+N/fqRlCxXGnqzVBZuCIJlTWzyoGKSkKVJ4DrwkPyeiTZbMt5uOhYARgR2fEYiqtaeP/0AuVqC0xweZFDRH/UZL+hbbKNxE6SYdW9qL9tfurv6vNzJ6izFnZsqDIjzZVhIRfQUxU4vANy5/HR4132r8+79EqU= Received: from AM6PR05MB6056.eurprd05.prod.outlook.com (20.179.2.148) by AM6PR05MB5749.eurprd05.prod.outlook.com (20.178.93.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1537.26; Thu, 17 Jan 2019 14:49:43 +0000 Received: from AM6PR05MB6056.eurprd05.prod.outlook.com ([fe80::5490:e4ea:7798:e65f]) by AM6PR05MB6056.eurprd05.prod.outlook.com ([fe80::5490:e4ea:7798:e65f%3]) with mapi id 15.20.1516.019; Thu, 17 Jan 2019 14:49:43 +0000 From: Ido Schimmel To: Florian Fainelli CC: "netdev@vger.kernel.org" , "andrew@lunn.ch" , "vivien.didelot@gmail.com" , "davem@davemloft.net" , Jiri Pirko , "ilias.apalodimas@linaro.org" , "ivan.khoronzhuk@linaro.org" , "roopa@cumulusnetworks.com" , "nikolay@cumulusnetworks.com" Subject: Re: [PATCH net-next 10/14] net: vlan: Propagate MC addresses with VID through switchdev Thread-Topic: [PATCH net-next 10/14] net: vlan: Propagate MC addresses with VID through switchdev Thread-Index: AQHUrdaTXmL4bqdifEuajacSaqxn6KWzjBOA Date: Thu, 17 Jan 2019 14:49:42 +0000 Message-ID: <20190117144941.GA24079@splinter> References: <20190116200102.2749-1-f.fainelli@gmail.com> <20190116200102.2749-11-f.fainelli@gmail.com> In-Reply-To: <20190116200102.2749-11-f.fainelli@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM5PR0701CA0003.eurprd07.prod.outlook.com (2603:10a6:203:51::13) To AM6PR05MB6056.eurprd05.prod.outlook.com (2603:10a6:20b:ab::20) authentication-results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM6PR05MB5749;6:dUgRQ5mbC3yKtkwGu9D3YsS2nr5k0IY/BqM9Qg7bZIBLRtOrOXt3BYtsS2diqnOMXrZxqAbL9w7TiIURPdYJ2SFnPmAORs//qdzpCkY24NeL4yl0ZfYw8H7zl5t8HSYXKhTePxJ10nR04vs8tvp2eXgL6gcLnJHiTp3jMAggtaJJMhqbnKE+ZT+KQWJdHAyKwQKZwayaqafFDAUPSxMYEhEBKfv+V+ElgbppT1Aa8lzXumWuybkY82y0YcVtJvbX6TgRxYOcbH7eo2Z2b3Gcnmcmk/etXRTWuspknL8lwg07pdBjQyXeoyHnu0XIMsuFWC6/5hyAwp+1LDKozE8thP9BhBzcYtgBYhhVrfRvkKu+ar5x45iByNOWpaSqfB8aawBZz/glK4j6VDSMjoqGsmzAaoGcJZ1ax2u/4RvxNvdH3UoAsIn8d7LEedQxDV/AncikvvLcfFS8zIUfyb/iyA==;5:1sWOAMkGt/+BQi4ttp+Y86mUZ7qhLsEIgFZc9kZ5749OLjTxsWrEwRl7Dd2LprDqDcLP29JwnnC19Dnx06g6hU4+cDktMgrqwJf2k7wlR5/fK0ud/nXHZBY6TOgjLCIQv0odX2Tkvyy5JNrOfbSGCBXa1UCte6wbfl+iyaEUGRH1D92uADxzL+p80x3Tk7qlfbgW12YNO41YB0vX1XX/kA==;7:p2ALkt2cDPgWkRwks0+a++bC+dZND8ek7IPxgs/kvO0WMgINhc3JgQhQ9Yay2L1FaV50Ct3KneKpGKehJYnZCmqgjVO9lSJ6DYqqgZ8Qy/pdACLy40kJE+Uc9W/gMXbgIbPRHQkRCvPjZIuRn6XnEQ== x-ms-office365-filtering-correlation-id: 81d3e7de-d337-437e-8189-08d67c8b03e2 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020);SRVR:AM6PR05MB5749; x-ms-traffictypediagnostic: AM6PR05MB5749: x-microsoft-antispam-prvs: x-forefront-prvs: 0920602B08 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(7916004)(396003)(346002)(376002)(366004)(39860400002)(136003)(199004)(189003)(6506007)(99286004)(71200400001)(39060400002)(6116002)(386003)(3846002)(5660300001)(76176011)(478600001)(6916009)(52116002)(33656002)(8676002)(66066001)(106356001)(86362001)(229853002)(68736007)(105586002)(316002)(33896004)(8936002)(14454004)(6436002)(486006)(7736002)(305945005)(81166006)(446003)(54906003)(2906002)(6486002)(4744005)(53936002)(6246003)(11346002)(25786009)(4326008)(476003)(81156014)(33716001)(1076003)(256004)(6512007)(9686003)(102836004)(71190400001)(26005)(97736004)(186003);DIR:OUT;SFP:1101;SCL:1;SRVR:AM6PR05MB5749;H:AM6PR05MB6056.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: M1OQqA6qMofu4K0qsgUX3fY8mLO8SrB3nywW9yA8/3U5FuGFMQM9mbPjJMTale/NzBMe2BO0Fx3Yh542Ziw0pj9jWXsznZ06GJEkavVgoEdCQ/ndWPML0sgUSHZ73j16jRR/zlIqs3J2Q81tdYms+ot5naRKZgVrWlKcWuGIxrK+xexjemoGIydZUIRMVdpr/dsLEjMv6VxMO9xtKOTWtqr5yw2gyu7iToArTq6dGxA/XLhMbq4mp3a0bzrH5x+C617mOms2VhQVo6Ml4+wpUZU8NCWpjiFTnZYpHhrvDmSQXHwbGX/iYCJGieaofq/pCqgocc6Rj9i2fXFg7xzQrTEgQVtP/C67RdqgUJWvdJJeid2g3HnRSbYfAEsZGsLab0z2+ajza/yWRqmWz3tLq+a11QYBk9cyjgEd29xsFD0= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 81d3e7de-d337-437e-8189-08d67c8b03e2 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jan 2019 14:49:42.5006 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB5749 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jan 16, 2019 at 12:00:58PM -0800, Florian Fainelli wrote: > The VLAN real device could be an Ethernet switch port and that switch > might have VLAN filtering globally enabled (because of a bridge > requesting VLAN filtering on the switch on another port) and so when > programming multicast addresses, we need the multicast filter > programming to be aware of the correct VLAN ID as well. This looks like a quirk of a specific device. How bad is it to patch the driver to add a multicast address for every configured VLAN? Also, I think it's weird that we have one API to program address and a completely different API (via switchdev) to program address+VID pairs. Extending current API might make more sense.