From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96A3BC1B0F7 for ; Fri, 18 Jan 2019 22:05:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6CDE22087E for ; Fri, 18 Jan 2019 22:05:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729880AbfARWFi (ORCPT ); Fri, 18 Jan 2019 17:05:38 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:47938 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729621AbfARWFi (ORCPT ); Fri, 18 Jan 2019 17:05:38 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id DDE161000537A; Fri, 18 Jan 2019 14:05:36 -0800 (PST) Date: Fri, 18 Jan 2019 14:05:36 -0800 (PST) Message-Id: <20190118.140536.1289771503734412771.davem@davemloft.net> To: ross.lagerwall@citrix.com Cc: netdev@vger.kernel.org, mostrows@earthlink.net, pablo@netfilter.org, kadlec@blackhole.kfki.hu, fw@strlen.de, roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org Subject: Re: [PATCH] net: Fix usage of pskb_trim_rcsum From: David Miller In-Reply-To: <20190117153438.32204-1-ross.lagerwall@citrix.com> References: <20190117153438.32204-1-ross.lagerwall@citrix.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 18 Jan 2019 14:05:37 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Ross Lagerwall Date: Thu, 17 Jan 2019 15:34:38 +0000 > In certain cases, pskb_trim_rcsum() may change skb pointers. > Reinitialize header pointers afterwards to avoid potential > use-after-frees. Add a note in the documentation of > pskb_trim_rcsum(). Found by KASAN. > > Signed-off-by: Ross Lagerwall Applied and queued up for -stable.