From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41EE1C1B0FD for ; Fri, 18 Jan 2019 22:14:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0AE3D20896 for ; Fri, 18 Jan 2019 22:14:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729992AbfARWOF (ORCPT ); Fri, 18 Jan 2019 17:14:05 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:48116 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729897AbfARWOE (ORCPT ); Fri, 18 Jan 2019 17:14:04 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 31A8213412228; Fri, 18 Jan 2019 14:14:04 -0800 (PST) Date: Fri, 18 Jan 2019 14:14:03 -0800 (PST) Message-Id: <20190118.141403.2038148706703776533.davem@davemloft.net> To: xiyou.wangcong@gmail.com Cc: netdev@vger.kernel.org, martin.olsson+netdev@sentorsecurity.com, jhs@mojatatu.com, jiri@resnulli.us Subject: Re: [Patch net-next] net_sched: add hit counter for matchall From: David Miller In-Reply-To: <20190117204425.27750-1-xiyou.wangcong@gmail.com> References: <20190117204425.27750-1-xiyou.wangcong@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 18 Jan 2019 14:14:04 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Cong Wang Date: Thu, 17 Jan 2019 12:44:25 -0800 > Although matchall always matches packets, however, it still > relies on a protocol match first. So it is still useful to have > such a counter for matchall. Of course, unlike u32, every time > we hit a matchall filter, it is always a success, so we don't > have to distinguish them. > > Sample output: > > filter protocol 802.1Q pref 100 matchall chain 0 > filter protocol 802.1Q pref 100 matchall chain 0 handle 0x1 > not_in_hw (rule hit 10) > action order 1: vlan pop continue > index 1 ref 1 bind 1 installed 40 sec used 1 sec > Action statistics: > Sent 836 bytes 10 pkt (dropped 0, overlimits 0 requeues 0) > backlog 0b 0p requeues 0 > > Reported-by: Martin Olsson > Cc: Jamal Hadi Salim > Cc: Jiri Pirko > Signed-off-by: Cong Wang Applied.