From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0C95C43387 for ; Fri, 18 Jan 2019 01:08:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ADE332086D for ; Fri, 18 Jan 2019 01:08:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RFHjmUSA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726185AbfARBI6 (ORCPT ); Thu, 17 Jan 2019 20:08:58 -0500 Received: from mail-qt1-f195.google.com ([209.85.160.195]:32916 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725981AbfARBI6 (ORCPT ); Thu, 17 Jan 2019 20:08:58 -0500 Received: by mail-qt1-f195.google.com with SMTP id l11so13640006qtp.0 for ; Thu, 17 Jan 2019 17:08:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QHRk3VzSVyl4kf1b/SH60NbCpQuvyILb2It2c5kKOCM=; b=RFHjmUSAnrvtDYRn1+guynP+A/JovIeELQ78vuKKrbaCty9vVQ9YG8Kl+plgEvlo3B 7B/SmlJOOdrwEQZl9fWmIvqNt8Ni0DySMfjqJQJ7UrKXk3BEmfgzkJ11TLJGfIcR+MJo 4ZSZ7XwDaepme2FaPGISHMga4bAFkxpHm6lT67ve/aTIT7moqCEgkGpOFX4+xj15BK5l XiXrToJMY/L7Js0DdTWcbFUic/fyzNHfSHEbyHA3OZkUaq6o3jgyciU35eiH8zeov50a lJ85uI1FtyiBz2ZTXyVJKpBreqwvd71+gGXnOVqtLSTpb9VoDGsfn9yGs4S42s8CO8fp VP9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QHRk3VzSVyl4kf1b/SH60NbCpQuvyILb2It2c5kKOCM=; b=BInA5xnGQp8X3xcYTK66JAChKbIqjHahjLga4ikKnywmvTIaHXb1T32Tp8apDFqRHk iVspS2XhD8luPHDm3sdYIytLRhvXjVoLgNf1egYklpSZg9JyKms3CCJWbo/6gFiEH26+ jgQKKDxo25wPF67QkXkkg7mR27kTu9MpX9xuhwCIov1Er6k155rA4mF0eQsO8uhd1iAG hbPdvT105+tKp0gqvf3RF1FdeprAPShTWYkZy+ov1maN0n96YABOFaSmbOQCMiiUvB1s Lieoy700ZB/sZvLZg2QNAoRCz3y50plrMVehv78myAjclYmf1rQMoQ3ZqBbWx26FC7wI CtiQ== X-Gm-Message-State: AJcUukf4NOJS56Zh5sMDVtFtaTtIay+6b8Wf2oIHtU9vFcnBjQG/8Um/ h3n1XhQKKn6VqN7fzVAUsZ9PxLVm X-Google-Smtp-Source: ALg8bN6NinNt7tPIhP8TzvkorYDpQBO5tBSA+9jBZE6HFJoSQCpbGso+L5t6T5eo7HHTNVSJtX1QYw== X-Received: by 2002:aed:3442:: with SMTP id w60mr14111865qtd.339.1547773737117; Thu, 17 Jan 2019 17:08:57 -0800 (PST) Received: from willemb1.nyc.corp.google.com ([2620:0:1003:315:3fa1:a34c:1128:1d39]) by smtp.gmail.com with ESMTPSA id a2sm24853880qkk.4.2019.01.17.17.08.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Jan 2019 17:08:56 -0800 (PST) From: Willem de Bruijn To: netdev@vger.kernel.org Cc: davem@davemloft.net, mst@redhat.com, jasowang@redhat.com, Willem de Bruijn , Mark Hlady Subject: [PATCH net-next] virtio-net: per-queue RPS config Date: Thu, 17 Jan 2019 20:08:53 -0500 Message-Id: <20190118010853.47325-1-willemdebruijn.kernel@gmail.com> X-Mailer: git-send-email 2.20.1.321.g9e740568ce-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Willem de Bruijn On multiqueue network devices, RPS maps are configured independently for each receive queue through /sys/class/net/$DEV/queues/rx-*. On virtio-net currently all packets use the map from rx-0, because the real rx queue is not known at time of map lookup by get_rps_cpu. Call skb_record_rx_queue in the driver rx path to make lookup work. Recording the receive queue has ramifications beyond RPS, such as in sticky load balancing decisions for sockets (skb_tx_hash) and XPS. Reported-by: Mark Hlady Signed-off-by: Willem de Bruijn --- drivers/net/virtio_net.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 0237250860467..236ba5d5fb4bb 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -1035,6 +1035,7 @@ static void receive_buf(struct virtnet_info *vi, struct receive_queue *rq, goto frame_err; } + skb_record_rx_queue(skb, vq2rxq(rq->vq)); skb->protocol = eth_type_trans(skb, dev); pr_debug("Receiving skb proto 0x%04x len %i type %i\n", ntohs(skb->protocol), skb->len, skb->pkt_type); -- 2.20.1.321.g9e740568ce-goog