From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8661C43387 for ; Fri, 18 Jan 2019 10:51:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AAB94204EC for ; Fri, 18 Jan 2019 10:51:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726952AbfARKvC (ORCPT ); Fri, 18 Jan 2019 05:51:02 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:45332 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726032AbfARKvC (ORCPT ); Fri, 18 Jan 2019 05:51:02 -0500 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 2864F80722; Fri, 18 Jan 2019 11:50:54 +0100 (CET) Date: Fri, 18 Jan 2019 11:50:59 +0100 From: Pavel Machek To: Marek Vasut Cc: Tristram.Ha@microchip.com, Sergio Paracuellos , Andrew Lunn , Florian Fainelli , Dan Carpenter , vivien.didelot@savoirfairelinux.com, UNGLinuxDriver@microchip.com, netdev@vger.kernel.org Subject: Re: [PATCH RFC 1/4] net: dsa: microchip: convert KSZ9477 SPI driver to use regmap Message-ID: <20190118105059.GA6100@amd> References: <1547695326-31553-1-git-send-email-Tristram.Ha@microchip.com> <1547695326-31553-2-git-send-email-Tristram.Ha@microchip.com> <62dc3a53-1c2e-aadf-f5b2-2f4ad75a201a@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vkogqOf2sHV7VnPd" Content-Disposition: inline In-Reply-To: <62dc3a53-1c2e-aadf-f5b2-2f4ad75a201a@denx.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --vkogqOf2sHV7VnPd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri 2019-01-18 07:29:35, Marek Vasut wrote: > On 1/17/19 4:22 AM, Tristram.Ha@microchip.com wrote: > > From: Tristram Ha > >=20 > > Convert KSZ9477 SPI driver to use regmap mechanism so that an I2C driver > > can be easily added. > >=20 > > KSZ9477 SPI driver uses a 32-bit SPI command containing a 24-bit address > > to access registers in 8-bit. The address is automatically increased to > > next register. In theory all registers can be read in one transfer as > > long as the buffer is enough. Therefore the regmap_raw_read and > > regmap_raw_write functions are used for basic 8-bit access. Two more > > regmap configurations are used for 16-bit and 32-bit accesses just that > > regmap_update_bits can be used. > >=20 > > All variables and functions associated with SPI access are removed. > >=20 > > Signed-off-by: Tristram Ha >=20 > These extremely patches look similar to what I posted here before: >=20 > https://patchwork.ozlabs.org/cover/1017222/ >=20 > But the authorship has changed. Why ? There seems to be explanation in 0/4. Tristram: if you started from Marek's patches as you describe in 0/4, you should mark respective patches as From: and Signed-off-by: Marek... Best regards, Pavel --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany --vkogqOf2sHV7VnPd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlxBr5MACgkQMOfwapXb+vJ9WwCfYEX8iOwM6WktSdKTq8QpfPfR yrIAniYyUcfc9p+iMLJa4zwnLDDSuftF =OdsT -----END PGP SIGNATURE----- --vkogqOf2sHV7VnPd--