From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55533C43612 for ; Fri, 18 Jan 2019 12:46:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1F94820896 for ; Fri, 18 Jan 2019 12:46:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KVwiyDrp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727779AbfARMqx (ORCPT ); Fri, 18 Jan 2019 07:46:53 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:53301 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727497AbfARMqw (ORCPT ); Fri, 18 Jan 2019 07:46:52 -0500 Received: by mail-wm1-f66.google.com with SMTP id d15so4385536wmb.3 for ; Fri, 18 Jan 2019 04:46:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=yHWdgyT1EKwhfTQtm337tYXjW3ZguoZS9jp45sZkcCk=; b=KVwiyDrpEmrIIJLabCD9+kCibTSfHKbRaXjFjopW9DznZCwM2jfZFCGow1Fzt68JY0 DJ6CIZ7CJwEcUHmhp4iXbUILIA/Ow/082NWt733N69ra8oLaijkk3tFhkFEW8s6kyoou 37tnj2N3tKhMRmPBGNc1LvpTxGs55NqIF/x5XtfzQIZZK5Iu3uRfew/Xd3LVrRF2kYS8 v0HZhHpAOzCtRECcqYaC7I5ROsqDao1jD/UUpS+dvueUJre0sqCl6AybQCI3S3LRZx14 JgHDn8dDDDuSkUCCMYeIWH+b9RjEZJQrOwCJ/0FI1tClpGMCGCfionJLsSucEdhV/bvK Zv/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=yHWdgyT1EKwhfTQtm337tYXjW3ZguoZS9jp45sZkcCk=; b=WGsD9Hy9Z7y0TeEGu16xSN26IsSkwZr341T8V/Cbbvg9zKKyF8xjk5rIyiHjP3Am1B texnbLJh3NCcu3J7VE6IhLDlDit/loxsq0Yah7p9lxANo6Z+P3sqidpMjyUMtVUUBcyO iesnSgLD1u1fXAoz1epD8NarmWUYRBNV4H6oLECepDiAnoBPPACvvpqhwGZXejeki2Vi BdWpmS7o7XSvLIjuMDTF5kvt8TxN5Bkaj9u2IrHhv2+PbBHVc+JtS1jawoSK8LRmmr7+ vPAHb1UK+BUDEHSPHMp5fqsfS6AQh9J8Ts/6FthQR7NwffNBSmwnag2FjahczTri8PcC nQsA== X-Gm-Message-State: AJcUukcHfP8A6fvUayiCMBY3gtjpUZFq7zy1TQJaQf2+JTXamJBobHiu BFp0h9ksgn+aAcDSNUi+mVnb8nac X-Google-Smtp-Source: ALg8bN55MabyYRXV5E68aeQ09H2kbyipU24V6eS9srQcGwfZN+cY6U+650AUsSVko5sNOKm42djedw== X-Received: by 2002:a1c:448a:: with SMTP id r132mr14999992wma.47.1547815610039; Fri, 18 Jan 2019 04:46:50 -0800 (PST) Received: from pluto.bluwirelesstechnology.com ([5.148.47.13]) by smtp.gmail.com with ESMTPSA id c202sm46845174wmd.40.2019.01.18.04.46.49 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Jan 2019 04:46:49 -0800 (PST) From: Dave McKay To: netdev@vger.kernel.org Subject: [PATCH] net: core: dev: Initialise napi state correctly Date: Fri, 18 Jan 2019 12:46:32 +0000 Message-Id: <20190118124632.17183-1-mckay.david@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The state member of the napi_struct is not initialised correctly, it sets the SCHED bit without initialising the state to zero first. This results in peculiar behaviour if the original napi_struct didn't come from a zero initialised region to start with. This patch just sets it directly using the appropriate bitfield constant. Signed-off-by: Dave McKay --- net/core/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/dev.c b/net/core/dev.c index 82f20022259d..250f97bf1973 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -6276,7 +6276,7 @@ void netif_napi_add(struct net_device *dev, struct napi_struct *napi, #ifdef CONFIG_NETPOLL napi->poll_owner = -1; #endif - set_bit(NAPI_STATE_SCHED, &napi->state); + napi->state = NAPIF_STATE_SCHED; napi_hash_add(napi); } EXPORT_SYMBOL(netif_napi_add); -- 2.20.1