From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD7B2C43387 for ; Fri, 18 Jan 2019 14:30:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 839662086D for ; Fri, 18 Jan 2019 14:30:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727444AbfAROay (ORCPT ); Fri, 18 Jan 2019 09:30:54 -0500 Received: from mail.us.es ([193.147.175.20]:46972 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727020AbfAROax (ORCPT ); Fri, 18 Jan 2019 09:30:53 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 103923EBA91 for ; Fri, 18 Jan 2019 15:30:52 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id F1725DA7F4 for ; Fri, 18 Jan 2019 15:30:51 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id E5C48DA86E; Fri, 18 Jan 2019 15:30:51 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 121E0DA84E; Fri, 18 Jan 2019 15:30:50 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Fri, 18 Jan 2019 15:30:50 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id E45594265A2F; Fri, 18 Jan 2019 15:30:49 +0100 (CET) Date: Fri, 18 Jan 2019 15:30:49 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: David Ahern Cc: wenxu@ucloud.cn, fw@strlen.de, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org Subject: Re: [PATCH v3] netfilter: nft_meta: Add NFT_META_I/OIFKIND meta type Message-ID: <20190118143049.i2wakdxsr5oonnl6@salvia> References: <1547596431-31824-1-git-send-email-wenxu@ucloud.cn> <20190118142430.rsnru4hyrbsodobf@salvia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Jan 18, 2019 at 07:27:48AM -0700, David Ahern wrote: > On 1/18/19 7:24 AM, Pablo Neira Ayuso wrote: > > > > There is no other way to identify a vft device rather than this > > string? The only l3mdev that exists if vrf, right? > > ipvlan uses some of the hooks. > > > > > If there is no other alternative, we can just place this in the tree, > > but probably it would be better to have a numeric way to identify a > > vrf device? > > IFF_L3MDEV_MASTER and IFF_L3MDEV_SLAVE are used via netif_is_l3_master > and netif_is_l3_slave in all of the code. This was done because of > requests to not bleed 'vrf' all over core kernel code. Thanks for explaining. So no other way than this string to identify vrf device, right?