From: "John W. Linville" <linville@tuxdriver.com>
To: Ivan Vecera <cera@cera.cz>
Cc: netdev@vger.kernel.org, "John W . Linville" <linville@redhat.com>
Subject: Re: [PATCH ethtool] ethtool: don't report UFO on kernels v4.14 and above
Date: Fri, 18 Jan 2019 13:39:13 -0500 [thread overview]
Message-ID: <20190118183913.GB30266@tuxdriver.com> (raw)
In-Reply-To: <20181129153653.766-1-cera@cera.cz>
On Thu, Nov 29, 2018 at 04:36:53PM +0100, Ivan Vecera wrote:
> Support for UDP fragmentation offloading was removed in kernel v4.14.
> The ethtool reports incorrectly its state on this and newer kernels:
>
> $ ethtool -k enp0s31f6 | grep udp-frag
> udp-fragmentation-offload: off
>
> It's look like that the feature is supported and disabled only. Instead
> of this behavior the status of UFO should not be reported on such kernels.
>
> As the UFO is only one feature that was removed from the ethtool I have
> decided after discussion with John to implement only simple check for
> this instead of implementing more generic solution like 'max_kernel_ver
> field in struct off_flag_def'.
>
> Cc: John W. Linville <linville@redhat.com>
> Signed-off-by: Ivan Vecera <cera@cera.cz>
Queued for next release.
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2019-01-18 18:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 15:36 [PATCH ethtool] ethtool: don't report UFO on kernels v4.14 and above Ivan Vecera
2019-01-18 18:39 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190118183913.GB30266@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=cera@cera.cz \
--cc=linville@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).