From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF85FC07EBF for ; Fri, 18 Jan 2019 18:45:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C803520850 for ; Fri, 18 Jan 2019 18:45:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728875AbfARSpQ (ORCPT ); Fri, 18 Jan 2019 13:45:16 -0500 Received: from charlotte.tuxdriver.com ([70.61.120.58]:43947 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728717AbfARSpQ (ORCPT ); Fri, 18 Jan 2019 13:45:16 -0500 Received: from uucp by smtp.tuxdriver.com with local-rmail (Exim 4.63) (envelope-from ) id 1gkZ8k-0008TB-5F; Fri, 18 Jan 2019 13:45:14 -0500 Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by localhost.localdomain (8.15.2/8.14.6) with ESMTP id x0IIdFMH011002; Fri, 18 Jan 2019 13:39:15 -0500 Received: (from linville@localhost) by localhost.localdomain (8.15.2/8.15.2/Submit) id x0IIdDQM011001; Fri, 18 Jan 2019 13:39:13 -0500 Date: Fri, 18 Jan 2019 13:39:13 -0500 From: "John W. Linville" To: Ivan Vecera Cc: netdev@vger.kernel.org, "John W . Linville" Subject: Re: [PATCH ethtool] ethtool: don't report UFO on kernels v4.14 and above Message-ID: <20190118183913.GB30266@tuxdriver.com> References: <20181129153653.766-1-cera@cera.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181129153653.766-1-cera@cera.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Nov 29, 2018 at 04:36:53PM +0100, Ivan Vecera wrote: > Support for UDP fragmentation offloading was removed in kernel v4.14. > The ethtool reports incorrectly its state on this and newer kernels: > > $ ethtool -k enp0s31f6 | grep udp-frag > udp-fragmentation-offload: off > > It's look like that the feature is supported and disabled only. Instead > of this behavior the status of UFO should not be reported on such kernels. > > As the UFO is only one feature that was removed from the ethtool I have > decided after discussion with John to implement only simple check for > this instead of implementing more generic solution like 'max_kernel_ver > field in struct off_flag_def'. > > Cc: John W. Linville > Signed-off-by: Ivan Vecera Queued for next release. -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.