From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=2z8z=P2=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 25DE0C5ACD3
	for <netdev@archiver.kernel.org>; Fri, 18 Jan 2019 18:45:23 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 02ECB2087E
	for <netdev@archiver.kernel.org>; Fri, 18 Jan 2019 18:45:23 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728928AbfARSpU (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Fri, 18 Jan 2019 13:45:20 -0500
Received: from charlotte.tuxdriver.com ([70.61.120.58]:43949 "EHLO
        smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728880AbfARSpT (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 18 Jan 2019 13:45:19 -0500
Received: from uucp by smtp.tuxdriver.com with local-rmail (Exim 4.63)
        (envelope-from <linville@tuxdriver.com>)
        id 1gkZ8j-0008T7-M6; Fri, 18 Jan 2019 13:45:13 -0500
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
        by localhost.localdomain (8.15.2/8.14.6) with ESMTP id x0IIe3Fa011062;
        Fri, 18 Jan 2019 13:40:03 -0500
Received: (from linville@localhost)
        by localhost.localdomain (8.15.2/8.15.2/Submit) id x0IIe262011061;
        Fri, 18 Jan 2019 13:40:02 -0500
Date:   Fri, 18 Jan 2019 13:40:02 -0500
From:   "John W. Linville" <linville@tuxdriver.com>
To:     Maciej =?utf-8?Q?=C5=BBenczykowski?= <zenczykowski@gmail.com>
Cc:     Maciej =?utf-8?Q?=C5=BBenczykowski?= <maze@google.com>,
        Jeff Garzik <jgarzik@pobox.com>,
        Ben Hutchings <ben@decadent.org.uk>,
        "David S . Miller" <davem@davemloft.net>,
        David Decotigny <decot@google.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] ethtool: zero initialize coalesce struct
Message-ID: <20190118184002.GC30266@tuxdriver.com>
References: <20181215011923.246179-1-zenczykowski@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20181215011923.246179-1-zenczykowski@gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Fri, Dec 14, 2018 at 05:19:23PM -0800, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@google.com>
> 
> prior to fetching it from kernel.
> 
> Otherwise we run the risk of very tail portion of it (dmac field)
> being left entirely uninitialized, and likely containing some sort
> of stale data.
> 
> It seems to likely be some sort of time (a second's counter).
> 
> Tested:
>   'ethtool -c eth1' with old kernel now reports 'dmac: 0' where
>   previously it reported some sort of second counter.
> 
> Signed-off-by: Maciej Żenczykowski <maze@google.com>

Queued for next release.

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.