From: Richard Cochran <richardcochran@gmail.com>
To: "Y.b. Lu" <yangbo.lu@nxp.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>
Subject: Re: [PATCH] net: dpaa2: build ptp clock driver in default
Date: Fri, 18 Jan 2019 12:14:44 -0800 [thread overview]
Message-ID: <20190118201444.d44uenasdgywhsyg@localhost> (raw)
In-Reply-To: <VI1PR0401MB223758879B4D76DB250AE64FF89C0@VI1PR0401MB2237.eurprd04.prod.outlook.com>
On Fri, Jan 18, 2019 at 07:18:32AM +0000, Y.b. Lu wrote:
> > We want to use "imply" instead of "select" here.
>
> [Y.b. Lu] Just learned the "imply" from the doc. I have a query here.
> Since this allows to configure PTP_1588_CLOCK out, the PHC APIs of FSL_DPAA2_PTP_CLOCK driver may not work.
> Doesn't it matter?
If PTP_1588_CLOCK is not compiled, then your driver should handle this
case:
* ptp_clock_register() - register a PTP hardware clock driver
* Returns a valid pointer on success or PTR_ERR on failure. If PHC
* support is missing at the configuration level, this function
* returns NULL, and drivers are expected to gracefully handle that
* case separately.
Thanks,
Richard
prev parent reply other threads:[~2019-01-18 20:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 9:44 [PATCH] net: dpaa2: build ptp clock driver in default Yangbo Lu
2019-01-18 1:25 ` Richard Cochran
2019-01-18 7:18 ` Y.b. Lu
2019-01-18 20:14 ` Richard Cochran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190118201444.d44uenasdgywhsyg@localhost \
--to=richardcochran@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ruxandra.radulescu@nxp.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox