From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA16FC5ACD5 for ; Fri, 18 Jan 2019 20:14:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9770920657 for ; Fri, 18 Jan 2019 20:14:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gKMEw59P" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729427AbfARUOu (ORCPT ); Fri, 18 Jan 2019 15:14:50 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:34383 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729356AbfARUOu (ORCPT ); Fri, 18 Jan 2019 15:14:50 -0500 Received: by mail-wm1-f65.google.com with SMTP id y185so1749162wmd.1 for ; Fri, 18 Jan 2019 12:14:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Sat/iNdrwu2sUg+izkC5k6A9ll1DMnuHSRfwRIxrCVw=; b=gKMEw59PH6w0bLgb6BLqfG8reCA8ypBBGHlZrqN5nTcR+pLEXCMAhtyUUKocui8aji a3cYMz+BAGZ52eVwS1jPSEud50SnNl/iBUT0tbE4/Oz9NRmBIl8ufBf37NTIb2Ea7M+A y46RbDiSC5ri62l9stOGFn7MSNsZbAj/3a/W69IBOiFa/aPCJEq/+bsnMbImc1bzbWJp 6Av84Fiu90LtlozpvjQzAPgL2cS77o9hQtugCUbaJrnhI+GCzCfX1QnYtqr5gTOAo54s oRSh6ialsmcHb4EVSzGfEfVgd6dFitUbCiZVklGEKAYm0VgjmgSdi0RAo7Y/wW9InKLb 9LwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Sat/iNdrwu2sUg+izkC5k6A9ll1DMnuHSRfwRIxrCVw=; b=WbaTL4r+VRHwvBfAJwEP6bIB7dPwnKlci2yaPPECtyI34oiMbDDCmPrLkwnHALvkbU o/hjzPrulyKF4jnTYxGVAg6ewxW+O/TtrPJaD4i9gScYX+X5ieJpMmwOW63lHBetyXy8 LZ6KsWu9fcyeB3USjikBlemyVxnBFfunUnQKjnDUyqHuBFU90MgA6/B2UlbTlbATpvAB M094SBTGXGb6IKrvsxKp0salsj2UXR2lw6wvPbG4xH/CaiekxQchnPYxmFwJ1oYzjKW4 bnMwC/g4Se9EQcck92tlnfl60yeXSWtV2K0OPWm7cxXRYYPt6jtcNw8UV4FVyDkxn4N+ GKxg== X-Gm-Message-State: AJcUukeAF3v1GoRchEduy5Jpzenp2A3cxyc+Xd07UE4mcUTgl+BKljyR R5DqhukkUAsRw2OmwL4NJUBRu0Ly X-Google-Smtp-Source: ALg8bN4HdHFUu+OQ/SeR1KJx44eq2zcW37BYp9SHoQnPJYsZGJHyFkeJL9NwkJvXOhIk87C5POzjdw== X-Received: by 2002:a1c:3282:: with SMTP id y124mr17399146wmy.134.1547842488281; Fri, 18 Jan 2019 12:14:48 -0800 (PST) Received: from localhost (83-215-98-136.stmi.dyn.salzburg-online.at. [83.215.98.136]) by smtp.gmail.com with ESMTPSA id 143sm85321920wml.14.2019.01.18.12.14.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 18 Jan 2019 12:14:47 -0800 (PST) Date: Fri, 18 Jan 2019 12:14:44 -0800 From: Richard Cochran To: "Y.b. Lu" Cc: "netdev@vger.kernel.org" , "David S . Miller" , Ioana Ciocoi Radulescu Subject: Re: [PATCH] net: dpaa2: build ptp clock driver in default Message-ID: <20190118201444.d44uenasdgywhsyg@localhost> References: <20190114094423.1204-1-yangbo.lu@nxp.com> <20190118012549.kmpnz434dyvn6biz@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Jan 18, 2019 at 07:18:32AM +0000, Y.b. Lu wrote: > > We want to use "imply" instead of "select" here. > > [Y.b. Lu] Just learned the "imply" from the doc. I have a query here. > Since this allows to configure PTP_1588_CLOCK out, the PHC APIs of FSL_DPAA2_PTP_CLOCK driver may not work. > Doesn't it matter? If PTP_1588_CLOCK is not compiled, then your driver should handle this case: * ptp_clock_register() - register a PTP hardware clock driver * Returns a valid pointer on success or PTR_ERR on failure. If PHC * support is missing at the configuration level, this function * returns NULL, and drivers are expected to gracefully handle that * case separately. Thanks, Richard