From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FBA2C61CE8 for ; Sat, 19 Jan 2019 17:53:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1F3302084F for ; Sat, 19 Jan 2019 17:53:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728907AbfASRxf convert rfc822-to-8bit (ORCPT ); Sat, 19 Jan 2019 12:53:35 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:56488 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728759AbfASRxe (ORCPT ); Sat, 19 Jan 2019 12:53:34 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 3AEBE14BC61BC; Sat, 19 Jan 2019 09:53:34 -0800 (PST) Date: Sat, 19 Jan 2019 09:53:31 -0800 (PST) Message-Id: <20190119.095331.1794689840010031847.davem@davemloft.net> To: toke@redhat.com Cc: netdev@vger.kernel.org Subject: Re: [PATCH v2] sch_api: Change signature of qdisc_tree_reduce_backlog() to use ints From: David Miller In-Reply-To: <20190109161057.18146-1-toke@redhat.com> References: <20190109161057.18146-1-toke@redhat.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 19 Jan 2019 09:53:34 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Toke Høiland-Jørgensen Date: Wed, 9 Jan 2019 17:10:57 +0100 > There are now several places where qdisc_tree_reduce_backlog() is called > with a negative number of packets (to signal an increase in number of > packets in the queue). Rather than rely on overflow behaviour, change the > function signature to use signed integers to communicate this usage to > people reading the code. > > Signed-off-by: Toke Høiland-Jørgensen Applied to net-next, thanks.