From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 657B6C26641 for ; Sun, 20 Jan 2019 18:45:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3641520861 for ; Sun, 20 Jan 2019 18:45:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727631AbfATSpd (ORCPT ); Sun, 20 Jan 2019 13:45:33 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:38782 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726541AbfATSpd (ORCPT ); Sun, 20 Jan 2019 13:45:33 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 8CB0D14C0F814; Sun, 20 Jan 2019 10:45:32 -0800 (PST) Date: Sun, 20 Jan 2019 10:45:29 -0800 (PST) Message-Id: <20190120.104529.77827546270091991.davem@davemloft.net> To: jiri@resnulli.us Cc: eranbe@mellanox.com, netdev@vger.kernel.org, jiri@mellanox.com, ariela@mellanox.com, ayal@mellanox.com, moshe@mellanox.com Subject: Re: [PATCH net-next v2 01/11] devlink: Add health buffer support From: David Miller In-Reply-To: <20190120110850.GD2730@nanopsycho> References: <20190120100352.GA2730@nanopsycho> <8c2185c4-ebb4-8fb2-a8ca-e523cd267f7b@mellanox.com> <20190120110850.GD2730@nanopsycho> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 20 Jan 2019 10:45:32 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jiri Pirko Date: Sun, 20 Jan 2019 12:08:50 +0100 > I haven't have time to review this due to travel. I think it was mistake > to merge this as the buffer api is wrong in my opinion. I would vote for > revert if possible. Let's spend a couple days trying to fix things up first. I cannot make contributors hostage to other people's travel schedule, no way. If it seems hopeless by Wednesday, I will revert. Thanks.