From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F272C6369F for ; Sun, 20 Jan 2019 10:12:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C19BF2087B for ; Sun, 20 Jan 2019 10:12:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="p41D9UVv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730448AbfATKMi (ORCPT ); Sun, 20 Jan 2019 05:12:38 -0500 Received: from mail-wm1-f49.google.com ([209.85.128.49]:39919 "EHLO mail-wm1-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730409AbfATKMh (ORCPT ); Sun, 20 Jan 2019 05:12:37 -0500 Received: by mail-wm1-f49.google.com with SMTP id y8so8153206wmi.4 for ; Sun, 20 Jan 2019 02:12:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=UhiuSGMW9GBgHG6ogqodjKshV8sldnCKX0ZfaX9c9uY=; b=p41D9UVvnxj73GUAUqtXl/AgrKt6Nix5zD4uI09bRte8AQEn92QYmv/DRbbe/FCsPr NuXGpoe8iPmvhntqxysgRc6vMTKmcIUx0dFTviV18dr23SEFvhP701Juv1KD1d/ZkEih icg/XiSPW4RhlL+/UZihUgTiVszkrMN3JrdHKyHhjFJl6vFkVeEv6eja+STShmUW+Pcy p7YjcRYz/reP78G0fQffJ02qOT7Wx8aL1Gimu+EpJmC291pXRcuqZJ1PAKrcgl6lYJ/3 U7ddF3v6TBz3FlWBv3UohFifSZBe9MLyoRTHOeW1iVkixH2kqydnqBD83r+P+5/GfwIA xdjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=UhiuSGMW9GBgHG6ogqodjKshV8sldnCKX0ZfaX9c9uY=; b=W35Fqse7OQuFHF+K8Alh01gaioPXjYmC4jxj8QM3+BIAnjVRvNaE/njCuW3JZHHNqu AVI9Y9O84V+EdbooCxhEbxJ/FhDeCnYXbzISZsZXThtHOkm3k9KI0vXaex6eYmnzCWlG mSVolC/RyRNOrX2pbI0IwFPI0DTgZngv7iknx+3q/iyHXaR2VxfBEe2BHFPex6mGnX1T nNRIidyK/pmBK+3BBrU95wJ2OjciPJblYtFe4aGN4AWMDw8OKIjJjORhw0TpG6zDxmsB UdvZF2S6a5SOf0bzD3ZHHNjTSqg1V2LZv3JthZ/wnZrTKvku9IRYUwi9qoaxaPshRj8f o4Ew== X-Gm-Message-State: AJcUukcfwujaBUjSlJqD0gc04O4/ICxEr1NU/6eHXSG6eTBo5Ae/OkQs +DoWnSNCPUVjmUacb8uyWTVGvA== X-Google-Smtp-Source: ALg8bN6imSmeG12s25Gl48rpov88d0DL+Nk2ZtkXapBG70BrOSNQygQwwhTXdt8BUmc969Cy9gSqWg== X-Received: by 2002:a1c:1d8e:: with SMTP id d136mr11527604wmd.98.1547979155864; Sun, 20 Jan 2019 02:12:35 -0800 (PST) Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id w80sm65861362wme.38.2019.01.20.02.12.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 20 Jan 2019 02:12:35 -0800 (PST) Date: Sun, 20 Jan 2019 11:03:52 +0100 From: Jiri Pirko To: Eran Ben Elisha Cc: netdev@vger.kernel.org, Jiri Pirko , "David S. Miller" , Ariel Almog , Aya Levin , Moshe Shemesh Subject: Re: [PATCH net-next v2 01/11] devlink: Add health buffer support Message-ID: <20190120100352.GA2730@nanopsycho> References: <1547762360-7075-1-git-send-email-eranbe@mellanox.com> <1547762360-7075-2-git-send-email-eranbe@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1547762360-7075-2-git-send-email-eranbe@mellanox.com> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Thu, Jan 17, 2019 at 10:59:10PM CET, eranbe@mellanox.com wrote: [...] >+static void >+devlink_health_buffers_destroy(struct devlink_health_buffer **buffers_list, >+ u64 size); Avoid fwd declarations. >+ >+static struct devlink_health_buffer ** >+devlink_health_buffers_create(u64 size) >+{ >+ struct devlink_health_buffer **buffers_list; >+ u64 num_of_buffers = DEVLINK_HEALTH_SIZE_TO_BUFFERS(size); >+ u64 i; >+ >+ buffers_list = kcalloc(num_of_buffers, >+ sizeof(struct devlink_health_buffer *), >+ GFP_KERNEL); >+ if (!buffers_list) >+ return NULL; >+ >+ for (i = 0; i < num_of_buffers; i++) { >+ struct devlink_health_buffer *buffer; >+ void *data; >+ >+ buffer = kzalloc(sizeof(*buffer), GFP_KERNEL); >+ data = kzalloc(DEVLINK_HEALTH_BUFFER_SIZE, GFP_KERNEL); >+ if (!buffer || !data) { >+ kfree(buffer); >+ kfree(data); >+ goto buffers_cleanup; >+ } >+ buffers_list[i] = buffer; >+ buffer->data = data; >+ } >+ devlink_health_buffers_reset(buffers_list, num_of_buffers); >+ >+ return buffers_list; >+ >+buffers_cleanup: >+ devlink_health_buffers_destroy(buffers_list, --i); Just do for-kfree here. >+ kfree(buffers_list); >+ return NULL; >+} >+ >+static void >+devlink_health_buffers_destroy(struct devlink_health_buffer **buffers_list, >+ u64 num_of_buffers) >+{ >+ u64 i; >+ >+ for (i = 0; i < num_of_buffers; i++) { >+ kfree(buffers_list[i]->data); >+ kfree(buffers_list[i]); >+ } >+} >+ [...]