From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13FDEC61CE4 for ; Sun, 20 Jan 2019 11:17:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D6CC72087E for ; Sun, 20 Jan 2019 11:17:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="v2QnZOFZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730525AbfATLRf (ORCPT ); Sun, 20 Jan 2019 06:17:35 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:45053 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730518AbfATLRf (ORCPT ); Sun, 20 Jan 2019 06:17:35 -0500 Received: by mail-wr1-f66.google.com with SMTP id z5so20031929wrt.11 for ; Sun, 20 Jan 2019 03:17:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=eoC2PgwJuJQ96jUH2xaPpzv/S5f/JVb5ayWU0Z7KW7g=; b=v2QnZOFZWzqABIBdDJCB/98xEpXh+XXywD7Mi61HKIIT2C6AfFW3j6TP/JPrfImcPy WDGdSb2mTAu1xqo5m+t7L95wJeKnKp5qgGTk4PrRhJwWObBDyb29uledPwC3ozLZWL4B AaDxqwhnMKdQA/MgZ8/lJbJtAzFMnoLT+gdl1tC9bav8zqbv8FXU/5BJ8VGw+0p8xh9G Z5UrurFesO3OxIQ7DCzaSfPREFhqyr9RsV6KrHnVwUYLdwb6ybyB89XKaBhK0jby6zAD BUmK3rg0ODBSYz1fG1Spnv+/18c9j90Lxa0BC+FvcgmKSvafAhDHihFkjQ9MRkOgnwct h4HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=eoC2PgwJuJQ96jUH2xaPpzv/S5f/JVb5ayWU0Z7KW7g=; b=fcDtoGdDcz2Kbtb5hDm78+LxKt80JmOUIDrzp4wSD01zkuRL7zqC/7b1WWgkd356km qPvIiGJ+BTMb+AADTtRhTh1hg9Cjfio96BuxqeTt8yyTxtg7AP+v8fCYqhC1IloQ9ahB 6S1vdKL6/obuxfySswzRfBkFGsADekj9Q9vdc5ZIMgu0Es/250b4ieXFbnjpwcp6xJ80 8LRS6gZ4DM9r8kmUwgf7BXafPUKqg9iVvEjOHzevFalNuHi2VC3XlzpnhwWrjPIiEfvh K4E4wQBu5bMZfIxVmXKCRwrHsie9pkvp+uVkbsuVYv4DqVmAmvL4fSWy+ISzOWeZkTjX HNSw== X-Gm-Message-State: AJcUukeNoh/gBBWBnIvsl1FOUbIo6U9zEX/o+ndC5ozrQZIUyMjbLoY1 /Y/pBv2/GSMqy/yDHZatMyg7GHekeHk= X-Google-Smtp-Source: ALg8bN7or/VF4Xom0IPRn/QeC83aVEzJz9203oTSblVSIZfwwqX2hD6D6iAILphokLbflTV/rQ5PlA== X-Received: by 2002:a05:6000:1251:: with SMTP id j17mr23148488wrx.315.1547983054165; Sun, 20 Jan 2019 03:17:34 -0800 (PST) Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id l15sm71205366wrw.4.2019.01.20.03.17.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 20 Jan 2019 03:17:33 -0800 (PST) Date: Sun, 20 Jan 2019 12:08:50 +0100 From: Jiri Pirko To: Eran Ben Elisha Cc: "netdev@vger.kernel.org" , Jiri Pirko , "David S. Miller" , Ariel Almog , Aya Levin , Moshe Shemesh Subject: Re: [PATCH net-next v2 01/11] devlink: Add health buffer support Message-ID: <20190120110850.GD2730@nanopsycho> References: <1547762360-7075-1-git-send-email-eranbe@mellanox.com> <1547762360-7075-2-git-send-email-eranbe@mellanox.com> <20190120100352.GA2730@nanopsycho> <8c2185c4-ebb4-8fb2-a8ca-e523cd267f7b@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8c2185c4-ebb4-8fb2-a8ca-e523cd267f7b@mellanox.com> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Sun, Jan 20, 2019 at 12:06:18PM CET, eranbe@mellanox.com wrote: > > >On 1/20/2019 12:03 PM, Jiri Pirko wrote: >> Thu, Jan 17, 2019 at 10:59:10PM CET, eranbe@mellanox.com wrote: >> >> [...] >> >>> +static void >>> +devlink_health_buffers_destroy(struct devlink_health_buffer **buffers_list, >>> + u64 size); >> >> Avoid fwd declarations. >> >> >>> + >>> +static struct devlink_health_buffer ** >>> +devlink_health_buffers_create(u64 size) >>> +{ >>> + struct devlink_health_buffer **buffers_list; >>> + u64 num_of_buffers = DEVLINK_HEALTH_SIZE_TO_BUFFERS(size); >>> + u64 i; >>> + >>> + buffers_list = kcalloc(num_of_buffers, >>> + sizeof(struct devlink_health_buffer *), >>> + GFP_KERNEL); >>> + if (!buffers_list) >>> + return NULL; >>> + >>> + for (i = 0; i < num_of_buffers; i++) { >>> + struct devlink_health_buffer *buffer; >>> + void *data; >>> + >>> + buffer = kzalloc(sizeof(*buffer), GFP_KERNEL); >>> + data = kzalloc(DEVLINK_HEALTH_BUFFER_SIZE, GFP_KERNEL); >>> + if (!buffer || !data) { >>> + kfree(buffer); >>> + kfree(data); >>> + goto buffers_cleanup; >>> + } >>> + buffers_list[i] = buffer; >>> + buffer->data = data; >>> + } >>> + devlink_health_buffers_reset(buffers_list, num_of_buffers); >>> + >>> + return buffers_list; >>> + >>> +buffers_cleanup: >>> + devlink_health_buffers_destroy(buffers_list, --i); >> >> Just do for-kfree here. >> >> >>> + kfree(buffers_list); >>> + return NULL; >>> +} >>> + >>> +static void >>> +devlink_health_buffers_destroy(struct devlink_health_buffer **buffers_list, >>> + u64 num_of_buffers) >>> +{ >>> + u64 i; >>> + >>> + for (i = 0; i < num_of_buffers; i++) { >>> + kfree(buffers_list[i]->data); >>> + kfree(buffers_list[i]); >>> + } >>> +} >>> + >> >> [...] >> > >Hi Jiri, >The series is merged. I can take the relevant comments as send as fix >with the rest of the series if you wish to. I haven't have time to review this due to travel. I think it was mistake to merge this as the buffer api is wrong in my opinion. I would vote for revert if possible.