From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E8C8C636A0 for ; Sun, 20 Jan 2019 11:36:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D2E312084C for ; Sun, 20 Jan 2019 11:36:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="ka8LKlF7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730559AbfATLgo (ORCPT ); Sun, 20 Jan 2019 06:36:44 -0500 Received: from mail-wm1-f44.google.com ([209.85.128.44]:53185 "EHLO mail-wm1-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730484AbfATLgm (ORCPT ); Sun, 20 Jan 2019 06:36:42 -0500 Received: by mail-wm1-f44.google.com with SMTP id m1so8310309wml.2 for ; Sun, 20 Jan 2019 03:36:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=tkhkdB+l9Y8IQeLwaUU7LoKAT7e3LUo7sq38ud3T9oY=; b=ka8LKlF7wn5cRERYWNnc/BsOY5lQFefv8v9Oh1FGv7yc8NjuG37tR0tuz/nVh0Uy0E vvH8VP4UUiCWYlTX3Er0tezztV6THl/10+yMbbv/jxyp1zdjk6DQ6ar2BjPvZE0/dHiA RjiVUDc47VszYGw7kYRwUH7tq+kOiPN+mOOBxYOsgNfVMGhLgqQNUzd5dUdszrAK0iI2 0cEYVpMa5vztGXxF0Wck8fVrirNtWP4yZNcUB7xbChvXjHYHTCsWnFRKgoZn2kwJtTVT 1fki8eiVijUG+3JPmYkMkb41baiZR+z+mTn2+WmQncGTtUl/uhRPvnw1Qh57RF0hUOVT eZqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=tkhkdB+l9Y8IQeLwaUU7LoKAT7e3LUo7sq38ud3T9oY=; b=kdg8mns9jMsM338GP0mQ9s6aLIKIMBkNb++JIjDrIWaMEEqlQo5fah+1KSB/sQKiZX CNuuIlxYibR5z9ac+MfLB7TcKxfvTFZWq1kQBLLllMtkLCp4NWsWjnU/WMIqO7POy3NP MFtIOZg2D/7ptiO8lsAmeGpqZ8fnjAHw0ewR4yYAfDgn6hcUf/0PAVM7OqZF3N5a9veV YMzR+BYp6f+VYmI3YEF1/PjhORhxX1OMcQ48rjm4qGh//H6JGx3U8Cn4jSr4gtaLk+U0 cLZ/lse0d/ij+2lu6gTUuxHAad8QUy+QMdwlCXmgrthW8x4rDtvoC+3EzBPUhvvBtnpP RTgQ== X-Gm-Message-State: AJcUukf39A7HOrN4NAZsdi+rm7dJASF6j4ub+DfxHhfXGlPrQsynsdEL UIzdfFvZf+WKTsJ7HVV17pFiptsHTS8= X-Google-Smtp-Source: ALg8bN6mhIyCpmcWwN4sFyBA3xmb064YgqNzAUpkF5srglJ37v9N+YlVSLz+GV19kOhd3ijg7ms8bQ== X-Received: by 2002:a1c:1383:: with SMTP id 125mr22121629wmt.71.1547984200057; Sun, 20 Jan 2019 03:36:40 -0800 (PST) Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id o16sm119988716wrn.11.2019.01.20.03.36.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 20 Jan 2019 03:36:39 -0800 (PST) Date: Sun, 20 Jan 2019 12:27:57 +0100 From: Jiri Pirko To: Eran Ben Elisha Cc: netdev@vger.kernel.org, Jiri Pirko , "David S. Miller" , Ariel Almog , Aya Levin , Moshe Shemesh Subject: Re: [PATCH net-next v2 03/11] devlink: Add health report functionality Message-ID: <20190120112757.GG2730@nanopsycho> References: <1547762360-7075-1-git-send-email-eranbe@mellanox.com> <1547762360-7075-4-git-send-email-eranbe@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1547762360-7075-4-git-send-email-eranbe@mellanox.com> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Thu, Jan 17, 2019 at 10:59:12PM CET, eranbe@mellanox.com wrote: [...] >+ >+TRACE_EVENT(devlink_health_recover_aborted, >+ TP_PROTO(const struct devlink *devlink, const char *reporter_name, >+ bool health_state, u64 time_since_last_recover), >+ >+ TP_ARGS(devlink, reporter_name, health_state, time_since_last_recover), >+ >+ TP_STRUCT__entry( >+ __string(bus_name, devlink->dev->bus->name) >+ __string(dev_name, dev_name(devlink->dev)) >+ __string(driver_name, devlink->dev->driver->name) >+ __string(reporter_name, reporter_name) >+ __field(bool, health_state) >+ __field(u64, time_since_last_recover) >+ ), >+ >+ TP_fast_assign( >+ __assign_str(bus_name, devlink->dev->bus->name); >+ __assign_str(dev_name, dev_name(devlink->dev)); >+ __assign_str(driver_name, devlink->dev->driver->name); >+ __assign_str(reporter_name, reporter_name); >+ __entry->health_state = health_state; >+ __entry->time_since_last_recover = time_since_last_recover; >+ ), >+ >+ TP_printk("bus_name=%s dev_name=%s driver_name=%s reporter_name=%s: health_state=%d time_since_last_recover = %llu recover aborted", Drop spaces around "=". Otherwise, this looks fine. Acked-by: Jiri Pirko