From: Jonathan Corbet <corbet@lwn.net>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Joe Perches <joe@perches.com>, Gal Pressman <galpress@amazon.com>,
Bart Van Assche <bvanassche@acm.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Tariq Toukan <tariqt@mellanox.com>,
xavier.huwei@huawei.com, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org, Doug Ledford <dledford@redhat.com>,
Stephen Warren <swarren@nvidia.com>,
Christoph Hellwig <hch@lst.de>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] coding-style: Clarify the expectations around bool
Date: Sun, 20 Jan 2019 19:08:00 -0700 [thread overview]
Message-ID: <20190120190800.64814cd4@lwn.net> (raw)
In-Reply-To: <20190118225047.GH4759@ziepe.ca>
On Fri, 18 Jan 2019 15:50:47 -0700
Jason Gunthorpe <jgg@ziepe.ca> wrote:
> There has been some confusion since checkpatch started warning about bool
> use in structures, and people have been avoiding using it.
>
> Many people feel there is still a legitimate place for bool in structures,
> so provide some guidance on bool usage derived from the entire thread that
> spawned the checkpatch warning.
>
> Link: https://lkml.kernel.org/r/CA+55aFwVZk1OfB9T2v014PTAKFhtVan_Zj2dOjnCy3x6E4UJfA@mail.gmail.com
> Signed-off-by: Joe Perches <joe@perches.com>
> Acked-by: Joe Perches <joe@perches.com>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
> Acked-by: Jani Nikula <jani.nikula@intel.com>
> Reviewed-by: Joey Pabalinas <joeypabalinas@gmail.com>
> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
So this seems ready; I've applied it.
Thanks,
jon
prev parent reply other threads:[~2019-01-21 8:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 22:50 [PATCH v5] coding-style: Clarify the expectations around bool Jason Gunthorpe
2019-01-20 8:36 ` Federico Vaga
2019-01-21 2:08 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190120190800.64814cd4@lwn.net \
--to=corbet@lwn.net \
--cc=akpm@linux-foundation.org \
--cc=bvanassche@acm.org \
--cc=dledford@redhat.com \
--cc=galpress@amazon.com \
--cc=hch@lst.de \
--cc=jgg@ziepe.ca \
--cc=joe@perches.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
--cc=tariqt@mellanox.com \
--cc=torvalds@linux-foundation.org \
--cc=xavier.huwei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).