From: gerg@kernel.org
To: sean.wang@mediatek.com, bjorn@mork.no, andrew@lunn.ch,
vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,
netdev@vger.kernel.org
Cc: rene@vdorst.com, john@phrozen.org, neil@brown.name
Subject: [PATCHv3 0/3]: net: support MT7530 switch in the MT7621 SoC
Date: Mon, 21 Jan 2019 17:11:37 +1000 [thread overview]
Message-ID: <20190121071140.23089-1-gerg@kernel.org> (raw)
This is the third version of a patch series supporting the MT7530 switch
as used in the MediaTek MT7621 SoC. Unlike the MediaTek MT7623 the MT7621
is built around a dual core MIPS CPU architecture. But inside it uses
basically the same 7530 switch.
This series resolves all issues I had with previous versions, and I can
now reliably use the driver on a 7621 SoC platform. These patches were
generated against linux-5.0-rc3.
The first patch enables support for the existing kernel mediatek ethernet
driver on the MT7621 SoC. This support is from Bjørn Mork, with an update
and fix by me. Using this driver fixed a number of problems I had
(TX checksums, large RX packet drop) over the staging driver
(drivers/staging/mt7621-eth).
Patch 2 modifies the mt7530 DSA driver to support the 7530 switch as
implemented in the Mediatek MT7621 SoC. The last patch updates the
devicetree bindings to reflect the new support in the mt7530 driver.
There is no real dependencies between the patches, so they can be taken
independantly.
Creating a new binding for the MT7621 seems like the only viable approach
to distinguish between a stand alone 7530 switch, the silicon module
in the MT7623 SoC and the silicon in the MT7621. Certainly the 7530 ID
register in the MT7623 and MT7621 returns the same value, "0x7530001".
Looking at the mt7530.c DSA driver it might make some sense to convert
the existing "mediatek,mcm" binding to something like "mediatek,mt7623"
to be consistent with this new MT7621 support. As far as I can tell
this is the intention of this binding.
Documentation/devicetree/bindings/net/dsa/mt7530.txt | 6 -
drivers/net/dsa/mt7530.c | 97 +++++++++++--------
drivers/net/dsa/mt7530.h | 9 +
drivers/net/ethernet/mediatek/Kconfig | 2
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 48 ++++++++-
drivers/net/ethernet/mediatek/mtk_eth_soc.h | 4
6 files changed, 118 insertions(+), 48 deletions(-)
v1: initial patch series
v2: rebase to linux-5.0-rc2
include mediatek ethernet driver changes
use devicetree binding to identify platform
v3: dropped mediatek ethernet driver auto negotiate patch
change devicetree binding text as per feedback
rebase onto 5.0-rc3
next reply other threads:[~2019-01-21 7:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 7:11 gerg [this message]
2019-01-21 7:11 ` [PATCHv3 1/3] net: ethernet: mediatek: support MT7621 SoC ethernet hardware gerg
2019-01-21 7:11 ` [PATCHv3 2/3] net: dsa: mt7530: support the 7530 switch on the Mediatek MT7621 SoC gerg
2019-01-21 16:56 ` kbuild test robot
2019-01-21 17:04 ` Andrew Lunn
2019-01-22 1:28 ` Greg Ungerer
2019-01-21 7:11 ` [PATCHv3 3/3] dt-bindings: net: dsa: add new MT7530 binding to support MT7621 gerg
2019-01-21 17:05 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121071140.23089-1-gerg@kernel.org \
--to=gerg@kernel.org \
--cc=andrew@lunn.ch \
--cc=bjorn@mork.no \
--cc=f.fainelli@gmail.com \
--cc=john@phrozen.org \
--cc=neil@brown.name \
--cc=netdev@vger.kernel.org \
--cc=rene@vdorst.com \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).