From: Ido Schimmel <idosch@idosch.org>
To: David Ahern <dsahern@gmail.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
netdev@vger.kernel.org, oss-drivers@netronome.com
Subject: Re: [PATCH iproute2] ip route: get: only set RTM_F_LOOKUP_TABLE flag for IPv4
Date: Mon, 21 Jan 2019 09:32:46 +0200 [thread overview]
Message-ID: <20190121073246.GA4717@splinter> (raw)
In-Reply-To: <24a5672e-a574-dfdc-3482-e86056e22939@gmail.com>
On Mon, Jan 14, 2019 at 09:29:51AM -0700, David Ahern wrote:
> On 1/14/19 9:05 AM, Stephen Hemminger wrote:
> > On Sat, 12 Jan 2019 12:54:06 -0800
> > Jakub Kicinski <jakub.kicinski@netronome.com> wrote:
> >
> >> Kernel ignores the RTM_F_LOOKUP_TABLE flag for all families
> >> but IPv4. Don't set it, otherwise it may fall foul of
> >> strict checking policies.
> >>
> >> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> >
> > Doing the right thing is a good idea, but really I can't see
> > the point of doing this. The kernel will always have to accept
> > requests from older versions of iproute2 (it can never be stricter)
> > because of ABI compatibility. So unless you can make a stronger
> > case for this; no not applying it.
> >
>
> iproute2 is often used as a reference model for features. Making
> iproute2 correct is the right thing to do regardless of whether what the
> kernel accepts.
>
> Current master branch is the first iproute2 to use the strict checking,
> and its first release with strict checking should have as many of these
> little one offs as possible fixed.
With current iproute2-next and net-next I get:
$ ip -6 route get 2001:db8:1::2
Error: ipv6: Invalid flags for get route request.
Are we going to patch the kernel to accept a flag it is not using or are
we going to patch iproute2 to not send it?
next prev parent reply other threads:[~2019-01-21 7:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-12 20:54 [PATCH iproute2] ip route: get: only set RTM_F_LOOKUP_TABLE flag for IPv4 Jakub Kicinski
2019-01-14 16:05 ` Stephen Hemminger
2019-01-14 16:29 ` David Ahern
2019-01-21 7:32 ` Ido Schimmel [this message]
2019-01-21 14:56 ` David Ahern
2019-01-22 16:32 ` David Ahern
2019-01-22 16:43 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121073246.GA4717@splinter \
--to=idosch@idosch.org \
--cc=dsahern@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).