From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96BFBC282DB for ; Mon, 21 Jan 2019 09:17:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5CF2A2084A for ; Mon, 21 Jan 2019 09:17:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="aXSJCPAG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727491AbfAUJRY (ORCPT ); Mon, 21 Jan 2019 04:17:24 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:45850 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725908AbfAUJRY (ORCPT ); Mon, 21 Jan 2019 04:17:24 -0500 Received: by mail-wr1-f65.google.com with SMTP id t6so22319064wrr.12 for ; Mon, 21 Jan 2019 01:17:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Xu/uNUraccGINej6nZ+SX6EmuxHLvb4pe7qAj6pJHxA=; b=aXSJCPAGSbtPeQMjvklUDSOsGXgzIkM/21ANBfgz5f0eaG5PBybz1HvOYL1IzXY54v inBE+6LukFAIT0Ane9i/Y/u179ZZqr+Ul7f6CiYORoyuwksyP9x5TU8PbEIDQ9wSHCoI kBhehBwhj/tXq75ZDQrCrh2Nk/fRRlH3VshE4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Xu/uNUraccGINej6nZ+SX6EmuxHLvb4pe7qAj6pJHxA=; b=F1jNJdLzqYFrP0SNfyZj16SBc8xYd40JX8LLmKm1tOCVn5tK3DBFKwfTwNWG5b68oS 4s9qBHaaHsdxh3etTWaS+qGpj1FpIGJxjBJkRFYD6vZn2on+cb7ge/gqJukRbDnTxlCE SV5vBV+QvUVglOLxDD+phcuOkVz/1bQZu2lpij6qfAH/9EHE6HyxZKLn+kButpsTUXAB NrQJD6/CeA7cc842hZkn+lk6oC/bc+9QIZMefFdrggJFtRePuIku0ohq6ZfjVtTROL6J RjWZ4xRTe4iPQ+BWi9tJ1AyGI1awnVf0Z/Xu6EfUArGH5QOfpwwBYo7lpgRfNE+RXH1j atfA== X-Gm-Message-State: AJcUukfAKhbkBE+Wxb2mnV4AyQOlLkMFzzN9Os5wY2ty1gggKTdJN0Gl MPWYp+Qw5g6vEp5e4DtGmoilvg== X-Google-Smtp-Source: ALg8bN4yUWu2uOu2bivXC9v8Yg7KAgZ5t3YLO7tTO7BaPsJi5UtM4HHaTvPgs5OFkurt9hLrrn1kWg== X-Received: by 2002:adf:ee46:: with SMTP id w6mr27900332wro.261.1548062241848; Mon, 21 Jan 2019 01:17:21 -0800 (PST) Received: from apalos (athedsl-373510.home.otenet.gr. [79.131.11.4]) by smtp.gmail.com with ESMTPSA id 60sm152753916wrb.81.2019.01.21.01.17.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Jan 2019 01:17:21 -0800 (PST) Date: Mon, 21 Jan 2019 11:17:18 +0200 From: Ilias Apalodimas To: Ido Schimmel Cc: Florian Fainelli , "netdev@vger.kernel.org" , "andrew@lunn.ch" , "vivien.didelot@gmail.com" , "davem@davemloft.net" , Jiri Pirko , "ivan.khoronzhuk@linaro.org" , "roopa@cumulusnetworks.com" , "nikolay@cumulusnetworks.com" Subject: Re: [PATCH net-next 10/14] net: vlan: Propagate MC addresses with VID through switchdev Message-ID: <20190121091718.GA29986@apalos> References: <20190116200102.2749-1-f.fainelli@gmail.com> <20190116200102.2749-11-f.fainelli@gmail.com> <20190117144941.GA24079@splinter> <026a9003-63cd-ab28-5e43-819f6fa5c1f8@gmail.com> <20190121091259.GB10994@splinter> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190121091259.GB10994@splinter> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Ido, > > > > The reason why I chose switchdev here is because: > > > > - this is mostly relevant for switch devices, not so much for NICs (it > > seems), if it was, they would have solved the problem by now > > I don't see any use of switchdev APIs in the driver Ivan is patching. > The cover letter doesn't indicate anything about it either. There were RFCs for it a few months ago https://patchwork.ozlabs.org/cover/929367/ We decided that rewriting the driver instead of adding switchdev support on the current one is cleaner and preferred, so we'll be posting a new driver for this at some point (most of the work is already done). > > > - this allows to have an unified path from the switch driver perspective > > to program MDB addresses targeting the CPU/management port, no need to > > have X different ways of doing the same operation > > But it's not the same thing. Allowing certain packets to ingress the > device is not the same as having the device send them to the CPU. We > have VLAN filters as well. Allowing VID X to ingress does not mean that > we trap each packet with this VID to CPU. /Ilias