From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15F79C282F6 for ; Mon, 21 Jan 2019 08:40:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D80EF20861 for ; Mon, 21 Jan 2019 08:40:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EZp1jYOI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729427AbfAUIj7 (ORCPT ); Mon, 21 Jan 2019 03:39:59 -0500 Received: from mail-lj1-f196.google.com ([209.85.208.196]:37878 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728824AbfAUIj7 (ORCPT ); Mon, 21 Jan 2019 03:39:59 -0500 Received: by mail-lj1-f196.google.com with SMTP id t18-v6so16788340ljd.4 for ; Mon, 21 Jan 2019 00:39:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3roVO2l9/N5W9slevkGXuK3rOhRWce0aiM/fsfO7IVg=; b=EZp1jYOIXVsb+UKXmaVRrH8Jw5swU1kCbQHV7BhnC0vr+2PEs1JXATG4zezngIRj6Y 9jaNybuBgeumkiaO6wPC/6LXyHiXMQxtznXdNirP7HUtL1pxPWt/S0wATDDV0jzw5tVL 2cv4s13HEHuyPgD0+A5r2g0bn1ncFL+Qq7ncll98YRs+uDe5DI/repj2vIfUgegdd4ud 0BPR1RbPJmBFs0y5h18QZsSx1lL+lFXJKoUMAVF34VqkiJV7We6soN9M73elNc6T1OcG ai9XKnYpXb9wS4q9lpOqMHbkQuYyT0Hq+U6dcyqv121iEdxW8nVBDAZaOKw/FvCCmZlF lvxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3roVO2l9/N5W9slevkGXuK3rOhRWce0aiM/fsfO7IVg=; b=hV2lweBr9rSuf+E6CKBqfLRu1/KLKnNn6a2Hz4eYiiRypRe9XN4IlEIvEDfjmPHcWL 8jZiYL4dr8Q6UKYfQWY8NxP0s5VKwX+hVyjj65HuU76jESaIJIjkzKnbEbR4El0anAVt N9/lI/pfaN31OV4mYn112p4ecceDpF1huE+ceDL/hISua24HyLw/wNotXDpXvI3esy0j pparCr1pxMIMFpvqi87U2Pd3k+bTz3JT2FvYgdxPpJP3PbK6kuxL/q9Hh9FmTvx1VxZE WcVyDe6BWSkeT6GWAoaUv9uckBBoMf1+kF0mJCqWLugFbHgHxjU1xxKmD/61AsROSt09 eW3Q== X-Gm-Message-State: AJcUukfcNB4j0yF3fTn2xQz/FmKoty4PiADPwCbs5ERh+oZzvnnUh9Zl Le2PhxXuC6wtmkFox27nkss= X-Google-Smtp-Source: ALg8bN5W42/GS/wrtpkg+i5Lm/NXJ+szfe3kNGZw/m04SsR4US++wyWAHrLTJb6Cmp2DbxmorwEImQ== X-Received: by 2002:a2e:841:: with SMTP id g1-v6mr18689946ljd.21.1548059996928; Mon, 21 Jan 2019 00:39:56 -0800 (PST) Received: from maciek-lenovo (host-185-93-94-63.ip-point.pl. [185.93.94.63]) by smtp.gmail.com with ESMTPSA id x29-v6sm2162557ljb.97.2019.01.21.00.39.56 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 21 Jan 2019 00:39:56 -0800 (PST) Date: Mon, 21 Jan 2019 09:39:53 +0100 From: Maciej =?UTF-8?B?RmlqYcWCa293c2tp?= To: Jesper Dangaard Brouer Cc: Alexei Starovoitov , Daniel Borkmann , Jakub Kicinski , netdev Subject: Re: [RFC bpf-next PATCH] samples/bpf: xdp_redirect_cpu have not need for read_trace_pipe Message-ID: <20190121093953.7d9e7b03@maciek-lenovo> In-Reply-To: <154772431797.12962.17869420707139270936.stgit@firesoul> References: <20190117121924.033d3106@redhat.com> <154772431797.12962.17869420707139270936.stgit@firesoul> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Dnia 2019-01-17, o godz. 12:26:47 Jesper Dangaard Brouer napisa=C5=82(a): > The sample xdp_redirect_cpu is not using helper bpf_trace_printk. > Thus it makes no sense that the --debug option us reading > from /sys/kernel/debug/tracing/trace_pipe via read_trace_pipe. > Simply remove it. >=20 > Signed-off-by: Jesper Dangaard Brouer > --- > I request that Maciej Fijalkowski > will take and integrate this patch in his patchset, such that > we can also complete the conversion of xdp_redirect_cpu to libbpf. > Let me include your patch and send a v2 :) > samples/bpf/xdp_redirect_cpu_user.c | 10 ---------- > 1 file changed, 10 deletions(-) >=20 > diff --git a/samples/bpf/xdp_redirect_cpu_user.c > b/samples/bpf/xdp_redirect_cpu_user.c index 2d23054aaccf..f141e752ca0a 10= 0644 > --- a/samples/bpf/xdp_redirect_cpu_user.c > +++ b/samples/bpf/xdp_redirect_cpu_user.c > @@ -51,7 +51,6 @@ static const struct option long_options[] =3D { > {"help", no_argument, NULL, 'h' }, > {"dev", required_argument, NULL, 'd' }, > {"skb-mode", no_argument, NULL, 'S' }, > - {"debug", no_argument, NULL, 'D' }, > {"sec", required_argument, NULL, 's' }, > {"prognum", required_argument, NULL, 'p' }, > {"qsize", required_argument, NULL, 'q' }, > @@ -563,7 +562,6 @@ int main(int argc, char **argv) > bool use_separators =3D true; > bool stress_mode =3D false; > char filename[256]; > - bool debug =3D false; > int added_cpus =3D 0; > int longindex =3D 0; > int interval =3D 2; > @@ -624,9 +622,6 @@ int main(int argc, char **argv) > case 'S': > xdp_flags |=3D XDP_FLAGS_SKB_MODE; > break; > - case 'D': > - debug =3D true; > - break; > case 'x': > stress_mode =3D true; > break; > @@ -688,11 +683,6 @@ int main(int argc, char **argv) > return EXIT_FAIL_XDP; > } > =20 > - if (debug) { > - printf("Debug-mode reading trace pipe (fix #define > DEBUG)\n"); > - read_trace_pipe(); > - } > - > stats_poll(interval, use_separators, prog_num, stress_mode); > return EXIT_OK; > } >=20