From: Matt Ellison <matt@arroyo.io>
To: David Ahern <dsahern@gmail.com>
Cc: netdev@vger.kernel.org, stephen@networkplumber.org
Subject: Re: [PATCH v2 iproute2] ip: support for xfrm interfaces
Date: Mon, 21 Jan 2019 12:05:14 -0500 [thread overview]
Message-ID: <20190121120514.080451d1@aquamarine> (raw)
In-Reply-To: <5767ec25-88ac-88f9-3ea8-31a90c0659d7@gmail.com>
On Mon, 21 Jan 2019 09:14:52 -0700 David Ahern <dsahern@gmail.com> wrote:
> You always add IF_ID even if not set by user. The kernel code does not
> appear to require it so why pass a default value?
0 (the default) is a valid IF_ID, so setting an interface with a non-zero IF_ID
back to 0 is possible. I think the better solution would be to check for existing
values so an "ip link set" doesn't try and automatically use 0 if unsepcified.
> The kernel code does appear to require this parameter, so why have
> this requirement in iproute2?
Looks to be required, without the check I get:
RTNETLINK answers: No such device
> What about IFLA_XFRM_LINK?
It shows up as the parent interface when you ip link show:
13: xfrm2@wlan0: <NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
link/none 48:e2:44:f6:77:51 brd ff:ff:ff:ff:ff:ff
But I can print it again if you think I should.
--
Please be advised that this email may contain confidential information.
If you are not the intended recipient, please notify us by email by
replying to the sender and delete this message. The sender disclaims that
the content of this email constitutes an offer to enter into, or the
acceptance of, any agreement; provided that the foregoing does not
invalidate the binding effect of any digital or other electronic
reproduction of a manual signature that is included in any attachment.
<https://twitter.com/arroyo_networks>
<https://www.linkedin.com/company/arroyo-networks>
<https://www.github.com/ArroyoNetworks>
next prev parent reply other threads:[~2019-01-21 17:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 14:40 [PATCH v2 iproute2] ip: support for xfrm interfaces Matt Ellison
2019-01-21 16:14 ` David Ahern
2019-01-21 17:05 ` Matt Ellison [this message]
2019-01-21 17:40 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121120514.080451d1@aquamarine \
--to=matt@arroyo.io \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).