From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA1A7FC619C for ; Mon, 21 Jan 2019 17:05:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8D9CD2089F for ; Mon, 21 Jan 2019 17:05:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=arroyo.io header.i=@arroyo.io header.b="DlTUCwJ3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726772AbfAURFT (ORCPT ); Mon, 21 Jan 2019 12:05:19 -0500 Received: from mail-it1-f196.google.com ([209.85.166.196]:35092 "EHLO mail-it1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725879AbfAURFS (ORCPT ); Mon, 21 Jan 2019 12:05:18 -0500 Received: by mail-it1-f196.google.com with SMTP id p197so16171230itp.0 for ; Mon, 21 Jan 2019 09:05:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arroyo.io; s=google; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version; bh=vasIfFFkztEQfiFEv7j+wmYZw0I1E7RpaUaC8irA/SU=; b=DlTUCwJ3njQQ7Jn5lL4HJqmywtKmSjwZ15PANdDkBVjq7envfgcaC07EpU5nkus8Zp aZbL7RBCVK54cR2L3yIveSU0c9CLY6E8AK891L9kZA8XjAygYQ95dpWmmt8BI6fTfTp6 effxNTSYjfsmw7SI2hjzcsDzuBOKHzJehZwDKrhMKkWkMGjcA6VQLaLFvqgYkyv8ibwo BgZTK39mnB+yXuM6cATRroYzEOyxUhUoeAQzS01H+RxgEkva48zX374FkShy0uLRTHSf G3nEc+joDgfvNN/8gD1pgJX9xWMZPdAOEDtmX11zyUcb6y9OhRXbmyqPO9jwK1wcq9rF sO+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version; bh=vasIfFFkztEQfiFEv7j+wmYZw0I1E7RpaUaC8irA/SU=; b=epidYtxjEUkyPFe0Y18oVotgD6qmjU3M/DgQTGdI0rbYQT64dQWjk3/din0ggwxlHc 87ACdwAxlzRsRioPttGZ3TeftpNf548Dm8JgU8kRFG/rcbQVd/VMKuNhRxDVtkLwXXVw 1PgSjxTPC/Al6qJDw7/bYqXwVl17512miB8Mqypkck0KAA18m5WJLIcQjdwMxQMDxBZz 9IyBzng1rU+55kCT4PZlp9bhME8IZZ4ccGW7HHQi2TCJcX7sSyluO10e9A3DYK8tbVtc S9xjifMskCqGGLH95icM7+JHP4DkhcUqFDicTLNYYjOWKihtM2XiESsdHPB/N1edWwfL Ut5w== X-Gm-Message-State: AJcUukc46FrqcA/q/gKSbkrRk9a0273voSQVhMB6LNx7Lq77gGj36JtP H/qTGCgxwVC5RHflq+9/M9Isk7l+aoXKjQKOGlMmRaj+f+pzloW2hBVojbhxgIWaXmrIcUhUFR5 tb332WQsn5ZjBAbN5bw== X-Google-Smtp-Source: ALg8bN4k9A1fIPAhmZXZEi7mgalXYRCOVvmiNHS5NwA0eZVGUb3XBhk9NhP9OhunLYpVS+CjRs62tg== X-Received: by 2002:a24:ef44:: with SMTP id i65mr124430ith.165.1548090317511; Mon, 21 Jan 2019 09:05:17 -0800 (PST) Received: from aquamarine (047-006-040-073.res.spectrum.com. [47.6.40.73]) by smtp.gmail.com with ESMTPSA id t2sm5762226iob.7.2019.01.21.09.05.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Jan 2019 09:05:17 -0800 (PST) Date: Mon, 21 Jan 2019 12:05:14 -0500 From: Matt Ellison To: David Ahern Cc: netdev@vger.kernel.org, stephen@networkplumber.org Subject: Re: [PATCH v2 iproute2] ip: support for xfrm interfaces Message-ID: <20190121120514.080451d1@aquamarine> In-Reply-To: <5767ec25-88ac-88f9-3ea8-31a90c0659d7@gmail.com> References: <20190117094037.36ea8631@aquamarine> <5767ec25-88ac-88f9-3ea8-31a90c0659d7@gmail.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 21 Jan 2019 09:14:52 -0700 David Ahern wrote: > You always add IF_ID even if not set by user. The kernel code does not > appear to require it so why pass a default value? 0 (the default) is a valid IF_ID, so setting an interface with a non-zero IF_ID back to 0 is possible. I think the better solution would be to check for existing values so an "ip link set" doesn't try and automatically use 0 if unsepcified. > The kernel code does appear to require this parameter, so why have > this requirement in iproute2? Looks to be required, without the check I get: RTNETLINK answers: No such device > What about IFLA_XFRM_LINK? It shows up as the parent interface when you ip link show: 13: xfrm2@wlan0: mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000 link/none 48:e2:44:f6:77:51 brd ff:ff:ff:ff:ff:ff But I can print it again if you think I should. -- Please be advised that this email may contain confidential information. If you are not the intended recipient, please notify us by email by replying to the sender and delete this message. The sender disclaims that the content of this email constitutes an offer to enter into, or the acceptance of, any agreement; provided that the foregoing does not invalidate the binding effect of any digital or other electronic reproduction of a manual signature that is included in any attachment.