From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BEF3C7112F for ; Mon, 21 Jan 2019 12:17:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4BB7B20879 for ; Mon, 21 Jan 2019 12:17:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="Jvpd8w9o" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728272AbfAUMRi (ORCPT ); Mon, 21 Jan 2019 07:17:38 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:36458 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727971AbfAUMRi (ORCPT ); Mon, 21 Jan 2019 07:17:38 -0500 Received: by mail-wm1-f67.google.com with SMTP id p6so10525437wmc.1 for ; Mon, 21 Jan 2019 04:17:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=tmUlFDsfO1KGl5I4OD39ETtXwr26ALjOJ++OgyA7dZM=; b=Jvpd8w9oISvzu/jWrzKZcicynSpT9JPiCuvitebgIcZ8RoYim885qFyKzgregJ3KoT +KHD/77GUS0ZmUeSyBSz7SNWG6dXspJCA4H4AHSdZkst062ftQ2w8zXjkuGkXKnJ3S7e 2HJo3vhjHKLwZNyFQYRUwGvvjrbZ5/iLi+N163GaB220ccVReHBSCZpkrsaQTi304YrR NOMiiUWI4XDypm+ARN3CrBIX3rTAdJUGPagQn7428F1eUlSJq3cqpu8csRIZC6x3EATG RYusTXRUrw2kNZvKG93KeytqB8vvwaP0nUs0G4EKRq5zEj18595uFvHFjuhSi73BRjeP P4Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=tmUlFDsfO1KGl5I4OD39ETtXwr26ALjOJ++OgyA7dZM=; b=MNIJIRz7XkXCjHi9C6Vy8tbhX2rOWunKmifN+F2tpsj6M+UWOT8e5Khbvvv21UijoR UBKdBM4Ef3mVS5jwM4pyVGOJbLsQTi0ObSFfprzXkLfqp/RZ2K3hD0iVYw+yxPdSlJ2+ Nv4KQ6Mi9x+4FHJXF/VLS7iH6CNYAzj6M5oE5JRhDxUbWE7F4TXdbHjZmHRQOMh/PFt2 cRnLHqGOUCqQR5nKdQmyiPQbSVDO5ce8HmgkLQ9zY932a0BzojS6nQgGWThom5tN4Pw9 MlcbCnMMbiNRr6O3d8KgcHSNsDFt8x9HhWut4zQZLHn6QyjWepf+aLhxgUOJbVMwX2t+ roFQ== X-Gm-Message-State: AJcUukeyK6jv3dA0943sHxmxEhPgUHEN/wVl+gznvoMgZfqdFWkiMygy 0pp6lUzbxRHxFrMWsdcpJXYpLw== X-Google-Smtp-Source: ALg8bN78w8j5sUDBGST5jr+LRtnAS8utAq5NCyq91OVW03y1trhDFmBbv6umnu8PccxqYuaSXXSVXw== X-Received: by 2002:a1c:9dc4:: with SMTP id g187mr25203744wme.152.1548073056161; Mon, 21 Jan 2019 04:17:36 -0800 (PST) Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id n82sm49128462wma.42.2019.01.21.04.17.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Jan 2019 04:17:32 -0800 (PST) Date: Mon, 21 Jan 2019 13:08:47 +0100 From: Jiri Pirko To: Eran Ben Elisha Cc: David Miller , "netdev@vger.kernel.org" , Jiri Pirko , Ariel Almog , Aya Levin , Moshe Shemesh Subject: Re: [PATCH net-next v2 01/11] devlink: Add health buffer support Message-ID: <20190121120847.GE2228@nanopsycho> References: <20190120100352.GA2730@nanopsycho> <8c2185c4-ebb4-8fb2-a8ca-e523cd267f7b@mellanox.com> <20190120110850.GD2730@nanopsycho> <20190120.104529.77827546270091991.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.5 (2018-04-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Mon, Jan 21, 2019 at 12:07:14PM CET, eranbe@mellanox.com wrote: > > >On 1/20/2019 8:45 PM, David Miller wrote: >> From: Jiri Pirko >> Date: Sun, 20 Jan 2019 12:08:50 +0100 >> >>> I haven't have time to review this due to travel. I think it was mistake >>> to merge this as the buffer api is wrong in my opinion. I would vote for >>> revert if possible. >> >> Let's spend a couple days trying to fix things up first. > >will do. >I reviewed the comments and saw that the major comment is around the >"Devlink buffers", which Jiri asked to replace with "Devlink msg". > >The issue is that there is no easy way to modify one into the other >without breaking things, so I am planning to provide a series on top >which does: >1. Add devlink msg API >2. Move devlink reporter to use new API >3. Move existing reporter to use the new API >4. Get rid of the old API Will be harder to review then revert and redo. Also harder for you to do the patches. Small nightmare :/ > >thanks, >Eran > >> >> I cannot make contributors hostage to other people's travel >> schedule, no way. >> >> If it seems hopeless by Wednesday, I will revert. > >Should be published by then, hopefully sooner. > >> >> Thanks. >>