From: Jiri Pirko <jiri@resnulli.us>
To: Eran Ben Elisha <eranbe@mellanox.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Jiri Pirko <jiri@mellanox.com>,
"David S. Miller" <davem@davemloft.net>,
Ariel Almog <ariela@mellanox.com>, Aya Levin <ayal@mellanox.com>,
Moshe Shemesh <moshe@mellanox.com>
Subject: Re: [PATCH net-next v2 09/11] net/mlx5e: Add TX reporter support
Date: Mon, 21 Jan 2019 13:11:54 +0100 [thread overview]
Message-ID: <20190121121154.GF2228@nanopsycho> (raw)
In-Reply-To: <05e949b6-030c-e51f-bdf1-7f159a5cbb55@mellanox.com>
Mon, Jan 21, 2019 at 12:32:07PM CET, eranbe@mellanox.com wrote:
>
>
>On 1/20/2019 1:06 PM, Jiri Pirko wrote:
>> Thu, Jan 17, 2019 at 10:59:18PM CET, eranbe@mellanox.com wrote:
[...]
>>> +static int
>>> +mlx5e_tx_reporter_build_diagnose_output(struct devlink_health_buffer *buffer,
>>> + u32 sqn, u8 state, u8 stopped)
>>> +{
>>> + int err, i;
>>> + int nest = 0;
>>> + char name[20];
>>> +
>>> + err = devlink_health_buffer_nest_start(buffer,
>>> + DEVLINK_ATTR_HEALTH_BUFFER_OBJECT);
>>> + if (err)
>>> + goto buffer_error;
>>> + nest++;
>>> +
>>> + err = devlink_health_buffer_nest_start(buffer,
>>> + DEVLINK_ATTR_HEALTH_BUFFER_OBJECT_PAIR);
>>> + if (err)
>>> + goto buffer_error;
>>> + nest++;
>>> +
>>> + sprintf(name, "SQ 0x%x", sqn);
>>
>> No. The whole idea of having the message build up with nested attributes
>> (json-like) was to avoid things like this. No sprintfs please. If you
>> want to do sprintf, most of the time you are doing something wrong.
>
>I wanted that each SQ object will have a unique name. But I can merge
>the sqn into its attributes instead.
Should be an array.
>
>>
>>
>>> + err = devlink_health_buffer_put_object_name(buffer, name);
>>> + if (err)
>>> + goto buffer_error;
>>> +
>>> + err = devlink_health_buffer_nest_start(buffer,
>>> + DEVLINK_ATTR_HEALTH_BUFFER_OBJECT_VALUE);
>>> + if (err)
>>> + goto buffer_error;
>>> + nest++;
>>> +
>>> + err = devlink_health_buffer_nest_start(buffer,
>>> + DEVLINK_ATTR_HEALTH_BUFFER_OBJECT);
>>> + if (err)
>>> + goto buffer_error;
>>> + nest++;
>>> +
>>> + err = devlink_health_buffer_nest_start(buffer,
>>> + DEVLINK_ATTR_HEALTH_BUFFER_OBJECT_PAIR);
>>> + if (err)
>>> + goto buffer_error;
>>> + nest++;
>>> +
>>> + err = devlink_health_buffer_put_object_name(buffer, "HW state");
>>> + if (err)
>>> + goto buffer_error;
>>> +
>>> + err = devlink_health_buffer_nest_start(buffer,
>>> + DEVLINK_ATTR_HEALTH_BUFFER_OBJECT_VALUE);
>>
>> How could you put an object name and don't start nesting? It looks
>> implicit to me.
>
>I will add some helper functions that you could review. Just keep in
>mind the implicit nest start must come with implicit nest end, so it
>won't fit into every use...
You can do just object_start(), object_finish() or something like that.
[...]
next prev parent reply other threads:[~2019-01-21 12:20 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 21:59 [PATCH net-next v2 00/11] Devlink health reporting and recovery system Eran Ben Elisha
2019-01-17 21:59 ` [PATCH net-next v2 01/11] devlink: Add health buffer support Eran Ben Elisha
2019-01-20 10:03 ` Jiri Pirko
2019-01-20 11:06 ` Eran Ben Elisha
2019-01-20 11:08 ` Jiri Pirko
2019-01-20 18:45 ` David Miller
2019-01-21 11:07 ` Eran Ben Elisha
2019-01-21 12:08 ` Jiri Pirko
2019-01-20 11:20 ` Jiri Pirko
2019-01-17 21:59 ` [PATCH net-next v2 02/11] devlink: Add health reporter create/destroy functionality Eran Ben Elisha
2019-01-20 11:49 ` Jiri Pirko
2019-01-17 21:59 ` [PATCH net-next v2 03/11] devlink: Add health report functionality Eran Ben Elisha
2019-01-20 11:27 ` Jiri Pirko
2019-01-21 11:12 ` Eran Ben Elisha
2019-01-17 21:59 ` [PATCH net-next v2 04/11] devlink: Add health get command Eran Ben Elisha
2019-01-20 11:31 ` Jiri Pirko
2019-01-17 21:59 ` [PATCH net-next v2 05/11] devlink: Add health set command Eran Ben Elisha
2019-01-20 11:32 ` Jiri Pirko
2019-01-17 21:59 ` [PATCH net-next v2 06/11] devlink: Add health recover command Eran Ben Elisha
2019-01-20 11:33 ` Jiri Pirko
2019-01-17 21:59 ` [PATCH net-next v2 07/11] devlink: Add health diagnose command Eran Ben Elisha
2019-01-20 11:38 ` Jiri Pirko
2019-01-17 21:59 ` [PATCH net-next v2 08/11] devlink: Add health dump {get,clear} commands Eran Ben Elisha
2019-01-17 21:59 ` [PATCH net-next v2 09/11] net/mlx5e: Add TX reporter support Eran Ben Elisha
2019-01-20 11:06 ` Jiri Pirko
2019-01-21 11:32 ` Eran Ben Elisha
2019-01-21 12:11 ` Jiri Pirko [this message]
2019-01-21 13:06 ` Eran Ben Elisha
2019-01-21 13:45 ` Jiri Pirko
2019-01-17 21:59 ` [PATCH net-next v2 10/11] net/mlx5e: Add TX timeout support for mlx5e TX reporter Eran Ben Elisha
2019-01-17 21:59 ` [PATCH net-next v2 11/11] devlink: Add Documentation/networking/devlink-health.txt Eran Ben Elisha
2019-01-18 22:59 ` [PATCH net-next v2 00/11] Devlink health reporting and recovery system David Miller
2019-01-20 9:27 ` [PATCH iproute2-next v2] devlink: Add health command support Aya Levin
2019-01-23 3:37 ` David Ahern
2019-01-23 11:27 ` Aya Levin
2019-01-24 0:27 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121121154.GF2228@nanopsycho \
--to=jiri@resnulli.us \
--cc=ariela@mellanox.com \
--cc=ayal@mellanox.com \
--cc=davem@davemloft.net \
--cc=eranbe@mellanox.com \
--cc=jiri@mellanox.com \
--cc=moshe@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox