From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54290C7112F for ; Mon, 21 Jan 2019 12:20:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D1F82084A for ; Mon, 21 Jan 2019 12:20:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="hG2k+v1u" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728605AbfAUMUl (ORCPT ); Mon, 21 Jan 2019 07:20:41 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:55592 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728268AbfAUMUk (ORCPT ); Mon, 21 Jan 2019 07:20:40 -0500 Received: by mail-wm1-f67.google.com with SMTP id y139so10496859wmc.5 for ; Mon, 21 Jan 2019 04:20:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1oFLV5AGAATaweg7Ql7u1EHVfKloft1aUDJzCR6UUxc=; b=hG2k+v1unz1+34pY6KZOPtl6lKIj2sqiPao1MqmIpFPsXSuTA6X4fKa3xpnkiPHlR2 L0RmZf/drpcAzQGArXJ7rSDCBg0QucTFj4LJIUcbfs/t28DcaWPB/CclWlQ8GP6EgK5O lIWnQwpYIgQm3mCDkyqJh97iEzcuTlEd4o6U2eH5DCgKA9CL5jDBpvXfnc0lHD+Wkf0t Htjrf9rCkjrMl6YLN72awCOOUfRMRfAR3O9jP/MHY7+Nl5SievIsrriqkX7R+g4u+e/u YbEiX/MP6CaoNDnvJjnAyD6GM3zKnMsOl78UE/x9hEnAlDqlRE1aisOlhETtfcU/Fi8M uB3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1oFLV5AGAATaweg7Ql7u1EHVfKloft1aUDJzCR6UUxc=; b=WVX1/pQf4G6loqvOfBDILnwei6VVue6wuMeG6T9aEgQqLc8bAwVRKHMGxKsByQdcF6 Gm30KUY06n3LyjxNQlFFmQ5j9VrBNCSwpFBfLDjB2Hh6B8um3s+Hr6sIQNXADrXpsIsR vV+FlhnBv/wCebDKdugEQ0g+JTPGJflKi7BcQeY/EPfcfSoyP1A1sBkfW+ZZnx+lohM7 va4sJFjwxjWOtxouLvWuSayQMQyqkjTBFMyI5q6h9T2lx70xSKvEjYNoRKQwyFA4d4ht mSwJf1V9h5nxOFp0of6TmZoGrfcevVnvgO97SWrYZARy+f0munfiVHeK3gTh4c1HXHvD 2ObQ== X-Gm-Message-State: AJcUukeVN86+cw8+f7jxnK6773jezhBnkRwQUEV6/ybAjY9O22Oid8f0 va+kCVHVNEkQReNlcBb2rLgZLA== X-Google-Smtp-Source: ALg8bN5mdj0mGjZg1alkf6uncxzpQYA3EpYIE/2mV4EnCX1qx6GdOVkkbFAea0RI1Gks70HNmkth7w== X-Received: by 2002:a1c:7f0c:: with SMTP id a12mr23878927wmd.89.1548073238848; Mon, 21 Jan 2019 04:20:38 -0800 (PST) Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id t66sm12554633wme.15.2019.01.21.04.20.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Jan 2019 04:20:38 -0800 (PST) Date: Mon, 21 Jan 2019 13:11:54 +0100 From: Jiri Pirko To: Eran Ben Elisha Cc: "netdev@vger.kernel.org" , Jiri Pirko , "David S. Miller" , Ariel Almog , Aya Levin , Moshe Shemesh Subject: Re: [PATCH net-next v2 09/11] net/mlx5e: Add TX reporter support Message-ID: <20190121121154.GF2228@nanopsycho> References: <1547762360-7075-1-git-send-email-eranbe@mellanox.com> <1547762360-7075-10-git-send-email-eranbe@mellanox.com> <20190120110618.GB2730@nanopsycho> <05e949b6-030c-e51f-bdf1-7f159a5cbb55@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <05e949b6-030c-e51f-bdf1-7f159a5cbb55@mellanox.com> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Mon, Jan 21, 2019 at 12:32:07PM CET, eranbe@mellanox.com wrote: > > >On 1/20/2019 1:06 PM, Jiri Pirko wrote: >> Thu, Jan 17, 2019 at 10:59:18PM CET, eranbe@mellanox.com wrote: [...] >>> +static int >>> +mlx5e_tx_reporter_build_diagnose_output(struct devlink_health_buffer *buffer, >>> + u32 sqn, u8 state, u8 stopped) >>> +{ >>> + int err, i; >>> + int nest = 0; >>> + char name[20]; >>> + >>> + err = devlink_health_buffer_nest_start(buffer, >>> + DEVLINK_ATTR_HEALTH_BUFFER_OBJECT); >>> + if (err) >>> + goto buffer_error; >>> + nest++; >>> + >>> + err = devlink_health_buffer_nest_start(buffer, >>> + DEVLINK_ATTR_HEALTH_BUFFER_OBJECT_PAIR); >>> + if (err) >>> + goto buffer_error; >>> + nest++; >>> + >>> + sprintf(name, "SQ 0x%x", sqn); >> >> No. The whole idea of having the message build up with nested attributes >> (json-like) was to avoid things like this. No sprintfs please. If you >> want to do sprintf, most of the time you are doing something wrong. > >I wanted that each SQ object will have a unique name. But I can merge >the sqn into its attributes instead. Should be an array. > >> >> >>> + err = devlink_health_buffer_put_object_name(buffer, name); >>> + if (err) >>> + goto buffer_error; >>> + >>> + err = devlink_health_buffer_nest_start(buffer, >>> + DEVLINK_ATTR_HEALTH_BUFFER_OBJECT_VALUE); >>> + if (err) >>> + goto buffer_error; >>> + nest++; >>> + >>> + err = devlink_health_buffer_nest_start(buffer, >>> + DEVLINK_ATTR_HEALTH_BUFFER_OBJECT); >>> + if (err) >>> + goto buffer_error; >>> + nest++; >>> + >>> + err = devlink_health_buffer_nest_start(buffer, >>> + DEVLINK_ATTR_HEALTH_BUFFER_OBJECT_PAIR); >>> + if (err) >>> + goto buffer_error; >>> + nest++; >>> + >>> + err = devlink_health_buffer_put_object_name(buffer, "HW state"); >>> + if (err) >>> + goto buffer_error; >>> + >>> + err = devlink_health_buffer_nest_start(buffer, >>> + DEVLINK_ATTR_HEALTH_BUFFER_OBJECT_VALUE); >> >> How could you put an object name and don't start nesting? It looks >> implicit to me. > >I will add some helper functions that you could review. Just keep in >mind the implicit nest start must come with implicit nest end, so it >won't fit into every use... You can do just object_start(), object_finish() or something like that. [...]