From: Andrew Lunn <andrew@lunn.ch>
To: "Guido Günther" <agx@sigxcpu.org>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] RFC: Revert "net: phy: check return code when requesting PHY driver module"
Date: Mon, 21 Jan 2019 17:26:00 +0100 [thread overview]
Message-ID: <20190121162600.GC8620@lunn.ch> (raw)
In-Reply-To: <20190121140055.GA7037@bogon.m.sigxcpu.org>
On Mon, Jan 21, 2019 at 03:00:55PM +0100, Guido Günther wrote:
> This unbreaks ethernet on e.g. the NXP imx8mq-evk using the fec driver.
> Otherwise it fails like:
>
> [ 3.702671] device: '30be0000.ethernet-1': device_add
> [ 3.707783] PM: Adding info for No Bus:30be0000.ethernet-1
> [ 3.713329] libphy: fec_enet_mii_bus: probed
> [ 3.717815] mdio_bus 30be0000.ethernet-1:01: error -2 loading PHY driver module for ID 0x004dd074
> [ 3.726747] PM: Removing info for No Bus:30be0000.ethernet-1
> [ 3.732460] device: 'pps0': device_unregister
> [ 3.736911] PM: Removing info for No Bus:pps0
> [ 3.741317] device: 'ptp0': device_unregister
> [ 3.745761] PM: Removing info for No Bus:ptp0
> [ 3.750160] device: 'ptp0': device_create_release
> [ 3.755024] fec 30be0000.ethernet: Dropping the link to regulator.2
> [ 3.761359] fec: probe of 30be0000.ethernet failed with error -2
>
> This reverts commit 13d0ab6750b20957ac1466da4e44dc0af746ff28.
Hi Guido
Please could you test:
https://www.spinics.net/lists/netdev/msg545573.html
Thanks
Andrew
next prev parent reply other threads:[~2019-01-21 16:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 14:00 [PATCH] RFC: Revert "net: phy: check return code when requesting PHY driver module" Guido Günther
2019-01-21 16:26 ` Andrew Lunn [this message]
2019-01-21 17:57 ` Guido Günther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121162600.GC8620@lunn.ch \
--to=andrew@lunn.ch \
--cc=agx@sigxcpu.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).