From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 056BAFC619C for ; Mon, 21 Jan 2019 17:04:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C11B42089F for ; Mon, 21 Jan 2019 17:04:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="KMkd0iZS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726268AbfAUREx (ORCPT ); Mon, 21 Jan 2019 12:04:53 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:50581 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725879AbfAUREx (ORCPT ); Mon, 21 Jan 2019 12:04:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=H+WfcFW/QfEZebYUWFcJvz26xJQmp5Nvsa8V8zSel2g=; b=KMkd0iZS/BLWrzKPbpXQeIlFtxshN4+hKern0m2vpt+wiUHLRMxETK7CJSNQiwazp+p0JNFD8G6D9qjT51kpBrq725xZCRdyyaVxkDRbnz6C1po0g+XkwyZUO6Crrsx0oG6o2jLPLthF2whCV9qc2F5RuqXK/CGb9ucDTp2DIYk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.84_2) (envelope-from ) id 1gld06-00039w-Vv; Mon, 21 Jan 2019 18:04:42 +0100 Date: Mon, 21 Jan 2019 18:04:42 +0100 From: Andrew Lunn To: gerg@kernel.org Cc: sean.wang@mediatek.com, bjorn@mork.no, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, netdev@vger.kernel.org, rene@vdorst.com, john@phrozen.org, neil@brown.name Subject: Re: [PATCHv3 2/3] net: dsa: mt7530: support the 7530 switch on the Mediatek MT7621 SoC Message-ID: <20190121170442.GH8620@lunn.ch> References: <20190121071140.23089-1-gerg@kernel.org> <20190121071140.23089-3-gerg@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190121071140.23089-3-gerg@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jan 21, 2019 at 05:11:39PM +1000, gerg@kernel.org wrote: > From: Greg Ungerer > > The MediaTek MT7621 SoC device contains a 7530 switch, and the existing > linux kernel 7530 DSA switch driver can be used with it. > > The bulk of the changes required stem from the 7621 having different > regulator and pad setup. The existing setup of these in the 7530 > driver appears to be very specific to its implemtation in the Mediatek > 7623 SoC. (Not entirely surprising given the 7623 is a quad core ARM > based SoC, and the 7621 is a dual core, dual thread MIPS based SoC). > > Create a new devicetree type, "mediatek,mt7621", to support the 7530 > switch in the 7621 SoC. There appears to be no usable ID register to > distinguish it from a 7530 in other hardware at runtime. This is used > to carry out the appropriate configuration and setup. > > Signed-off-by: Greg Ungerer Reviewed-by: Andrew Lunn Andrew