From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60FAEC31680 for ; Mon, 21 Jan 2019 17:13:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2234120663 for ; Mon, 21 Jan 2019 17:13:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="4hRN6Pb5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727302AbfAURN0 (ORCPT ); Mon, 21 Jan 2019 12:13:26 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:50622 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727140AbfAURN0 (ORCPT ); Mon, 21 Jan 2019 12:13:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=HbJ2ezV/5QZ5vPNg/B9FHaf76LH3ioUhiBNpVJebOSM=; b=4hRN6Pb5dIsDEc6ud2rt2ub7ZXIE7jRiw0xCQNi4aJiJ/U1r/TH87EzUlLD1bRfjKHoLA2NrsN3r5AZxERm1+hkE8t5afz/gtvlOdigxQKANDjMcM6r+Wt/+K6Vsf22Z5kplDlsIbu9R+QiEfdtuZyV5uEjBkSMKlYdyaGY+DrM=; Received: from andrew by vps0.lunn.ch with local (Exim 4.84_2) (envelope-from ) id 1gld8V-0003Qn-Ck; Mon, 21 Jan 2019 18:13:23 +0100 Date: Mon, 21 Jan 2019 18:13:23 +0100 From: Andrew Lunn To: Igor Russkikh Cc: "David S . Miller" , "netdev@vger.kernel.org" , Nikita Danilov Subject: Re: [PATCH net 5/5] net: aquantia: added err var into AQ_HW_WAIT_FOR construct Message-ID: <20190121171323.GK8620@lunn.ch> References: <8bae843a7f567eb7187cf7b84372d96e4914b3e7.1547878835.git.igor.russkikh@aquantia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8bae843a7f567eb7187cf7b84372d96e4914b3e7.1547878835.git.igor.russkikh@aquantia.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jan 21, 2019 at 02:53:53PM +0000, Igor Russkikh wrote: > From: Nikita Danilov > > David noticed this define was hiding 'err' variable > reference. Thats confusing and counterintuitive. > > Adding err argument explicitly for better visibility > that err is changed inside macro. > > Signed-off-by: Nikita Danilov > Signed-off-by: Igor Russkikh > --- > .../ethernet/aquantia/atlantic/aq_hw_utils.h | 4 ++-- > .../aquantia/atlantic/hw_atl/hw_atl_a0.c | 8 ++++---- > .../aquantia/atlantic/hw_atl/hw_atl_b0.c | 4 ++-- > .../aquantia/atlantic/hw_atl/hw_atl_utils.c | 18 +++++++++--------- > .../atlantic/hw_atl/hw_atl_utils_fw2x.c | 10 +++++----- > 5 files changed, 22 insertions(+), 22 deletions(-) > > diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_hw_utils.h b/drivers/net/ethernet/aquantia/atlantic/aq_hw_utils.h > index dc88a1221f1d..ca1d20d64a39 100644 > --- a/drivers/net/ethernet/aquantia/atlantic/aq_hw_utils.h > +++ b/drivers/net/ethernet/aquantia/atlantic/aq_hw_utils.h > @@ -23,7 +23,7 @@ > > #define AQ_HW_SLEEP(_US_) mdelay(_US_) > > -#define AQ_HW_WAIT_FOR(_B_, _US_, _N_) \ > +#define AQ_HW_WAIT_FOR(_B_, _US_, _N_, _err_) \ > do { \ > unsigned int AQ_HW_WAIT_FOR_i; \ > for (AQ_HW_WAIT_FOR_i = _N_; (!(_B_)) && (AQ_HW_WAIT_FOR_i);\ > @@ -31,7 +31,7 @@ do { \ > udelay(_US_); \ > } \ > if (!AQ_HW_WAIT_FOR_i) {\ > - err = -ETIME; \ > + *(_err_) = -ETIME; \ > } \ > } while (0) Hi Igor How about throwing this horrible macro away and using one of the readx_poll_timeout() variants. Andrew