From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01684C31680 for ; Mon, 21 Jan 2019 17:57:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB2092084A for ; Mon, 21 Jan 2019 17:57:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726418AbfAUR5U (ORCPT ); Mon, 21 Jan 2019 12:57:20 -0500 Received: from honk.sigxcpu.org ([24.134.29.49]:39757 "EHLO honk.sigxcpu.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725908AbfAUR5U (ORCPT ); Mon, 21 Jan 2019 12:57:20 -0500 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id EB539FB03; Mon, 21 Jan 2019 18:57:18 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cWR8c1KFHNKW; Mon, 21 Jan 2019 18:57:17 +0100 (CET) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id 4A34848DD1; Mon, 21 Jan 2019 18:57:17 +0100 (CET) Date: Mon, 21 Jan 2019 18:57:17 +0100 From: Guido =?iso-8859-1?Q?G=FCnther?= To: Andrew Lunn Cc: Heiner Kallweit , Florian Fainelli , "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH] RFC: Revert "net: phy: check return code when requesting PHY driver module" Message-ID: <20190121175717.GA30032@bogon.m.sigxcpu.org> References: <20190121140055.GA7037@bogon.m.sigxcpu.org> <20190121162600.GC8620@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190121162600.GC8620@lunn.ch> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, On Mon, Jan 21, 2019 at 05:26:00PM +0100, Andrew Lunn wrote: > On Mon, Jan 21, 2019 at 03:00:55PM +0100, Guido Günther wrote: > > This unbreaks ethernet on e.g. the NXP imx8mq-evk using the fec driver. > > Otherwise it fails like: > > > > [ 3.702671] device: '30be0000.ethernet-1': device_add > > [ 3.707783] PM: Adding info for No Bus:30be0000.ethernet-1 > > [ 3.713329] libphy: fec_enet_mii_bus: probed > > [ 3.717815] mdio_bus 30be0000.ethernet-1:01: error -2 loading PHY driver module for ID 0x004dd074 > > [ 3.726747] PM: Removing info for No Bus:30be0000.ethernet-1 > > [ 3.732460] device: 'pps0': device_unregister > > [ 3.736911] PM: Removing info for No Bus:pps0 > > [ 3.741317] device: 'ptp0': device_unregister > > [ 3.745761] PM: Removing info for No Bus:ptp0 > > [ 3.750160] device: 'ptp0': device_create_release > > [ 3.755024] fec 30be0000.ethernet: Dropping the link to regulator.2 > > [ 3.761359] fec: probe of 30be0000.ethernet failed with error -2 > > > > This reverts commit 13d0ab6750b20957ac1466da4e44dc0af746ff28. > > Hi Guido > > Please could you test: > > https://www.spinics.net/lists/netdev/msg545573.html Yes, that works. There's indeed no initramfs in this case and the module is built into the kernel. Feel free to add a Tested-By: Guido Günther Cheers, -- Guido