From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ECC0C282C3 for ; Tue, 22 Jan 2019 22:38:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F0E2D20866 for ; Tue, 22 Jan 2019 22:38:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727113AbfAVWiI (ORCPT ); Tue, 22 Jan 2019 17:38:08 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:37188 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726218AbfAVWiH (ORCPT ); Tue, 22 Jan 2019 17:38:07 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 45D3314D43D5C; Tue, 22 Jan 2019 14:38:07 -0800 (PST) Date: Tue, 22 Jan 2019 14:38:06 -0800 (PST) Message-Id: <20190122.143806.797408195853155408.davem@davemloft.net> To: mckay.david@gmail.com Cc: netdev@vger.kernel.org Subject: Re: [PATCH] net: core: dev: Initialise napi state correctly From: David Miller In-Reply-To: <20190118124632.17183-1-mckay.david@gmail.com> References: <20190118124632.17183-1-mckay.david@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 22 Jan 2019 14:38:07 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Dave McKay Date: Fri, 18 Jan 2019 12:46:32 +0000 > The state member of the napi_struct is not initialised correctly, it > sets the SCHED bit without initialising the state to zero first. This > results in peculiar behaviour if the original napi_struct didn't come > from a zero initialised region to start with. > > This patch just sets it directly using the appropriate bitfield > constant. > > Signed-off-by: Dave McKay Caller needs to pass in properly initialized memory, that means bzero()'d.