From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00727C282C0 for ; Wed, 23 Jan 2019 05:00:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CDA83217F5 for ; Wed, 23 Jan 2019 05:00:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726026AbfAWFAu (ORCPT ); Wed, 23 Jan 2019 00:00:50 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:40756 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725899AbfAWFAu (ORCPT ); Wed, 23 Jan 2019 00:00:50 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id E2E6C101594D6; Tue, 22 Jan 2019 21:00:49 -0800 (PST) Date: Tue, 22 Jan 2019 21:00:49 -0800 (PST) Message-Id: <20190122.210049.740424638207753657.davem@davemloft.net> To: natechancellor@gmail.com Cc: jiri@mellanox.com, eranbe@mellanox.com, moshe@mellanox.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] devlink: Use DIV_ROUND_UP_ULL in DEVLINK_HEALTH_SIZE_TO_BUFFERS From: David Miller In-Reply-To: <20190122042301.14142-1-natechancellor@gmail.com> References: <20190122042301.14142-1-natechancellor@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 22 Jan 2019 21:00:50 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Nathan Chancellor Date: Mon, 21 Jan 2019 21:23:01 -0700 > When building this code on a 32-bit platform such as ARM, there is a > link time error (lld error shown, happpens with ld.bfd too): > > ld.lld: error: undefined symbol: __aeabi_uldivmod >>>> referenced by devlink.c >>>> net/core/devlink.o:(devlink_health_buffers_create) in archive built-in.a > > This happens when using a regular division symbol with a u64 dividend. > Use DIV_ROUND_UP_ULL, which wraps do_div, to avoid this situation. > > Fixes: cb5ccfbe73b3 ("devlink: Add health buffer support") > Signed-off-by: Nathan Chancellor Applied to net-next.