Re: [PATCH net-next 0/7] Devlink health updates

[Jiri Pirko <jiri@resnulli.us>]

Tue, Jan 22, 2019 at 04:57:17PM CET, eranbe@mellanox.com wrote:
>This patchset fixes some comments that were received for the devlink
>health series, mostly around the devlink health buffers API.
>
>It offers a new devlink<->driver API for passing health dump and diagnose info.
>As part of this patchset, the new API is developed and integrated into the
>devlink health and mlx5e TX reporter.
>Also, added some helpers together with the new API, which reduce the code
>required by the driver to fill dump and diagnose significantly.
>
>Eventually, it also deletes the old API.
>
>In addition, it includes some small fixes in the devlink and mlx5e TX reporter.

Okay, just leaving, going to review this tomorrow. I would much rather
review the patchset from the beginning, not this incremental patchset.
It changes a lot of things, deprecating api what was just introduced.
Review nightmare :/

Could we do revert, repost? For my health sakes :)

Thanks!


>
>
>Eran Ben Elisha (7):
>  devlink: Add devlink msg API
>  net/mlx5e: Move driver to use devlink msg API
>  devlink: move devlink health reporter to use devlink msg API
>  devlink: Delete depracated health buffers API
>  devlink: Remove spaces around "=" in the logger print
>  devlink: Fix use-after-free at reporter destroy
>  net/mlx5e: Add RTNL lock to TX recover flow
>
> .../mellanox/mlx5/core/en/reporter_tx.c       | 124 +---
> include/net/devlink.h                         |  79 +--
> include/trace/events/devlink.h                |   2 +-
> include/uapi/linux/devlink.h                  |  14 +-
> net/core/devlink.c                            | 633 ++++++++----------
> 5 files changed, 342 insertions(+), 510 deletions(-)
>
>-- 
>2.17.1
>