From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3B1EC282C3 for ; Tue, 22 Jan 2019 17:07:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7396920866 for ; Tue, 22 Jan 2019 17:07:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="Jw3xjMn0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729542AbfAVRHK (ORCPT ); Tue, 22 Jan 2019 12:07:10 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:45605 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729400AbfAVRHK (ORCPT ); Tue, 22 Jan 2019 12:07:10 -0500 Received: by mail-wr1-f67.google.com with SMTP id t6so28192254wrr.12 for ; Tue, 22 Jan 2019 09:07:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=GN8+SDGh9ma3a1dWq/A9Rx1gCzZyWrsYqJec4eKs7rk=; b=Jw3xjMn09jb5yW06/ejQFKV4NvDe+F8Frjh01ni6K9+5nnXywYcINtD/rnVEpZ49yA hnaOHDUDm0ju29niv48F753KXxl9kb6/QuVbpdPU1opPB3lE1l5MFq2AcZlGK68y4xSS TPZM9KGUui7xKeTXi3OsaGcPF2IQVL0nkGqg2GcP917KtfyNGnXtmjsU1+5nCR24hbvu FBPq4XPS9UEYATqhhPvGsMU+eJ84RxjvQV+OTRNVIx9Y+htAOO6EaxriNzmHYtgDExDB tIAakDRRq9U69V9CuKzBhRxKbRUOKbdsNnCAZpjhkCu6kw+14k/zKyPWZ8ewP4WcAZWE JhOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=GN8+SDGh9ma3a1dWq/A9Rx1gCzZyWrsYqJec4eKs7rk=; b=ctibQRyuRcBb4B/B4Cxqu1iqFPtZ/f/YSfrUO0vyF0U9ds/ebvOp03dN7e2hOG2f60 w9sHv6h/0+CH2tvGHfEW/wFK6OsIImI/Fd9n+A1mAREo0EL2DzwDnYYkvjgiwW7QgkR9 r/vVdNMJytZzS+D+4/7h+bi8UdBDLTBADM1ipNuTf9q8YA26mUW8WYBXA1SfCMvR5xiO QcVPCHWegAHM6yMzxdILFi4aGgW4pOWZTCEuUAjxqUfr8aeCC2yXHyInsyGl/h7tyU1r DvRv52nVJO2rOSipaCXULL24A+PyzUqDrL9V+9urmKMNeR1oZ6ILksGjCbkTjaMBzerc CDHQ== X-Gm-Message-State: AJcUukcV6wEMezSqSvYCXaULzOeKE+cApu3gfGSwwKBBcBN4kSZ52ztc Agzt5jJpC5nGyOwvTH/bEHyz4g== X-Google-Smtp-Source: ALg8bN7/g1Q2sVIWuR6R+FQDClWrcBlx5VH4KrKDj5g93tPFGjhd3ImMcfGI6vLXCkNPSTzpR2ZJkw== X-Received: by 2002:adf:9ec8:: with SMTP id b8mr35289841wrf.164.1548176828130; Tue, 22 Jan 2019 09:07:08 -0800 (PST) Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id o8sm95993279wrx.15.2019.01.22.09.07.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Jan 2019 09:07:07 -0800 (PST) Date: Tue, 22 Jan 2019 17:58:21 +0100 From: Jiri Pirko To: Eran Ben Elisha Cc: netdev@vger.kernel.org, Jiri Pirko , "David S. Miller" , Saeed Mahameed , Moshe Shemesh Subject: Re: [PATCH net-next 0/7] Devlink health updates Message-ID: <20190122165821.GC2121@nanopsycho> References: <1548172644-30862-1-git-send-email-eranbe@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1548172644-30862-1-git-send-email-eranbe@mellanox.com> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Tue, Jan 22, 2019 at 04:57:17PM CET, eranbe@mellanox.com wrote: >This patchset fixes some comments that were received for the devlink >health series, mostly around the devlink health buffers API. > >It offers a new devlink<->driver API for passing health dump and diagnose info. >As part of this patchset, the new API is developed and integrated into the >devlink health and mlx5e TX reporter. >Also, added some helpers together with the new API, which reduce the code >required by the driver to fill dump and diagnose significantly. > >Eventually, it also deletes the old API. > >In addition, it includes some small fixes in the devlink and mlx5e TX reporter. Okay, just leaving, going to review this tomorrow. I would much rather review the patchset from the beginning, not this incremental patchset. It changes a lot of things, deprecating api what was just introduced. Review nightmare :/ Could we do revert, repost? For my health sakes :) Thanks! > > >Eran Ben Elisha (7): > devlink: Add devlink msg API > net/mlx5e: Move driver to use devlink msg API > devlink: move devlink health reporter to use devlink msg API > devlink: Delete depracated health buffers API > devlink: Remove spaces around "=" in the logger print > devlink: Fix use-after-free at reporter destroy > net/mlx5e: Add RTNL lock to TX recover flow > > .../mellanox/mlx5/core/en/reporter_tx.c | 124 +--- > include/net/devlink.h | 79 +-- > include/trace/events/devlink.h | 2 +- > include/uapi/linux/devlink.h | 14 +- > net/core/devlink.c | 633 ++++++++---------- > 5 files changed, 342 insertions(+), 510 deletions(-) > >-- >2.17.1 >