From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C76BEC282C3 for ; Tue, 22 Jan 2019 18:03:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8E4FA21019 for ; Tue, 22 Jan 2019 18:03:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="rZhubz7A" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726112AbfAVSDB (ORCPT ); Tue, 22 Jan 2019 13:03:01 -0500 Received: from mail-it1-f201.google.com ([209.85.166.201]:53437 "EHLO mail-it1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725862AbfAVSDB (ORCPT ); Tue, 22 Jan 2019 13:03:01 -0500 Received: by mail-it1-f201.google.com with SMTP id i12so14148349ita.3 for ; Tue, 22 Jan 2019 10:03:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=nunpKTmpZxICXDGa7tn8Emk6A4uZuyRLOikp0kJAnZ4=; b=rZhubz7A25/oopTcr5qt3D0Sy19zSr4oCDEfNaOStfU1fcCplLf3BddjC/bNSuQ9K1 jkS3a/WLWebsmdIemxT2k/odfulu6pDCuBK7ls0nR4gGXD8O8+kTafXfcPLnXSl5G2kP 71OHMia9xknRgV/wa2nRU32BYQ1UaKLtDzmyDbFt/XZwAMrkX2Ct04MAw31BEAisEZYW BD3dMZAfKB2tQ7mKDGqoZ43CsOC3XyMAl835/jjsWqE5cViuPOdjHjMGFS3EOZQT6jPm TUbVwmMLd9DEhh9gSqTAutGV/Pr0ivLKakgPMcaptIR9vUHwptjBTUY3UTz32oiLVE1z X0Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=nunpKTmpZxICXDGa7tn8Emk6A4uZuyRLOikp0kJAnZ4=; b=ThWu7/1myeHUBIyWjBACyqk9CoLYv0nML38bU4w19Gdd+IUdMFqCdJcgDPKSBsfSlz bkcjxD1AHTUYYZelFH/XEDsiCOXv2QsRJ8CoRuSEj4L6nz7FOgs7mmdL3FzbrenHtIBE mOiOrJlVq+nkg86HO7n9yMXp/KBJNGKAPsddADJ2MWKvWa5bARzD4hKSTdaXTyJ4JOtY gN343afr8VFjq1jeUIhThnFFZeuxtojb9JIxbCKkzCG1rpIcuhjRn4FJAY2u8jilvmy4 Zl6r/VXB7j4w7gRShsJbver7B8BUDALkbn1SeOR3aE1EfcXwZ3oVYmS1OQDkBwLEOS7c Fc5g== X-Gm-Message-State: AJcUukesR9hWU2nCotz3RFkEOnnl5ud+MmkKqzY6nNlN6aALLFuKZ9Uz +t8F18sXMamsDCSybS2ncU1qCET8 X-Google-Smtp-Source: ALg8bN7DfhAFd+xo2a/OS0URNs93YJSSOtvGbHXYTysLNkv2MzOv9fvn0nT4VMymAgN+yf/D3LEUsEXV X-Received: by 2002:a24:4105:: with SMTP id x5mr1308640ita.33.1548180180315; Tue, 22 Jan 2019 10:03:00 -0800 (PST) Date: Tue, 22 Jan 2019 10:02:49 -0800 Message-Id: <20190122180253.128336-1-posk@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.20.1.321.g9e740568ce-goog Subject: [PATCH net-next 0/4] net: IP defrag: use rbtrees in IPv6 defragmentation From: Peter Oskolkov To: David Miller , netdev@vger.kernel.org Cc: Peter Oskolkov , Peter Oskolkov Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Currently, IPv6 defragmentation code drops non-last fragments that are smaller than 1280 bytes: see commit 0ed4229b08c1 ("ipv6: defrag: drop non-last frags smaller than min mtu") This behavior is not specified in IPv6 RFCs and appears to break compatibility with some IPv6 implementations, as reported here: https://www.spinics.net/lists/netdev/msg543846.html This patchset contains four patches: - patch 1 moves rbtree-related code from IPv4 to files shared b/w IPv4/IPv6 - patch 2 changes IPv6 defragmenation code to use rbtrees for defrag queue - patch 3 changes nf_conntrack IPv6 defragmentation code to use rbtrees - patch 4 changes ip_defrag selftest to test changes made in the previous three patches. Along the way, the 1280-byte restrictions are removed. I plan to introduce similar changes to 6lowpan defragmentation code once I figure out how to test it. Peter Oskolkov (4): net: IP defrag: encapsulate rbtree defrag code into callable functions net: IP6 defrag: use rbtrees for IPv6 defrag net: IP6 defrag: use rbtrees in nf_conntrack_reasm.c selftests: net: ip_defrag: cover new IPv6 defrag behavior include/net/inet_frag.h | 16 +- include/net/ipv6_frag.h | 11 +- net/ipv4/inet_fragment.c | 293 +++++++++++++++++++++++ net/ipv4/ip_fragment.c | 289 +++------------------- net/ipv6/netfilter/nf_conntrack_reasm.c | 260 ++++++-------------- net/ipv6/reassembly.c | 233 +++++------------- tools/testing/selftests/net/ip_defrag.c | 69 +++--- tools/testing/selftests/net/ip_defrag.sh | 16 ++ 8 files changed, 527 insertions(+), 660 deletions(-) -- 2.20.1.321.g9e740568ce-goog