From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=FRzW=P7=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 0CF59C282C0
	for <netdev@archiver.kernel.org>; Wed, 23 Jan 2019 19:18:19 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id DD65521872
	for <netdev@archiver.kernel.org>; Wed, 23 Jan 2019 19:18:18 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726738AbfAWTSS (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Wed, 23 Jan 2019 14:18:18 -0500
Received: from shards.monkeyblade.net ([23.128.96.9]:48622 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725976AbfAWTSR (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 23 Jan 2019 14:18:17 -0500
Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 3294814EE2771;
        Wed, 23 Jan 2019 11:18:17 -0800 (PST)
Date:   Wed, 23 Jan 2019 11:18:16 -0800 (PST)
Message-Id: <20190123.111816.391923974506708545.davem@davemloft.net>
To:     edumazet@google.com
Cc:     netdev@vger.kernel.org, eric.dumazet@gmail.com,
        ralf@linux-mips.org, syzkaller@googlegroups.com
Subject: Re: [PATCH net] ax25: fix possible use-after-free
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190122184059.220252-1-edumazet@google.com>
References: <20190122184059.220252-1-edumazet@google.com>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 23 Jan 2019 11:18:17 -0800 (PST)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

From: Eric Dumazet <edumazet@google.com>
Date: Tue, 22 Jan 2019 10:40:59 -0800

> syzbot found that ax25 routes where not properly protected
> against concurrent use [1].
> 
> In this particular report the bug happened while
> copying ax25->digipeat.
> 
> Fix this problem by making sure we call ax25_get_route()
> while ax25_route_lock is held, so that no modification
> could happen while using the route.
> 
> The current two ax25_get_route() callers do not sleep,
> so this change should be fine.
> 
> Once we do that, ax25_get_route() no longer needs to
> grab a reference on the found route.
> 
> [1]
 ...
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Reported-by: syzbot <syzkaller@googlegroups.com>

Applied.