From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79EC1C282C0 for ; Wed, 23 Jan 2019 06:41:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 47C5621019 for ; Wed, 23 Jan 2019 06:41:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bQ+8oylg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726291AbfAWGlv (ORCPT ); Wed, 23 Jan 2019 01:41:51 -0500 Received: from mail-pf1-f176.google.com ([209.85.210.176]:36375 "EHLO mail-pf1-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725973AbfAWGlv (ORCPT ); Wed, 23 Jan 2019 01:41:51 -0500 Received: by mail-pf1-f176.google.com with SMTP id b85so682834pfc.3 for ; Tue, 22 Jan 2019 22:41:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5ZdpEWsauGbJl42shLxgckgLI+DlQI02u8vVHR8uogY=; b=bQ+8oylgW5yDF8FQiNbpHsecLzKvbWXgKjlonIpStK5Qf4SefVZgAy2YgfAwiHdfJN 8np42gtjeOvCuhiUwqldNCLrm9obEXvQZnmuqRuV+oiieuAFT3DszJ6wGwSepvvkxUvN t2y/WnChuFtXHk04O+BZBXNcw8Y801wfbVDFJ4RA93UuxTKG9KYPHi9CV4BvOMleazP0 tbHfcGJ1pRpoA7iuiRQyGrhq2p18WPAHOTUbmGGAqH0FxZGPsp9h344n1zQ3NX+Zcyu1 383g8nKZo9hB8fNdONX9tzNzDc1MYIuj48pansbFD5NXE4cReXbOSD/S1owH4BXQ7O0R BEeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5ZdpEWsauGbJl42shLxgckgLI+DlQI02u8vVHR8uogY=; b=KR7oL8LSq6Da1AxdItH7Tr3qEIlxz52T5TKx/LgFz06Ecdn9OWClWYM2j7ca1zhT/p 86i0dUJ1cY0/50Za4HcErVZslrof8Ppu+AGINSAaEk/YiNXICGIh83KFx3ZYPEP0WXmE m93iv3V0++jMInKPgZ+pWCBwsogRH5xnXu1A+hTOnvd67vVzYTppNESesGhE8Fmj0XK6 llPBSn1I0pQNXdZfw+KKiqG96DgHTj8WX6VQw3Qy8z4EOrVgny46mzIKx0JvgtAlORCi igUSf2ed6Q1ljrcE7Cwhat/vLsiH4V4sfaOa5dEA+lL4xddt3NrTf63ZXF8Cbstj1KNi bxhQ== X-Gm-Message-State: AJcUukdkwdN7UfTjeC8cfyVlvsFaPpLKJ/eErhkTyeONixKh3+1iU+9t uHG6eT5h9pAAjhUGOy6fzv7MYA2t X-Google-Smtp-Source: ALg8bN6pzEsz8OrRTy0bBR/q1ZvEQAEH4ys3lB6gcQlUEGsCWCfnOSQG4bSFX9IKdYpSlnFtyXjWVA== X-Received: by 2002:a62:4181:: with SMTP id g1mr1002707pfd.45.1548225709725; Tue, 22 Jan 2019 22:41:49 -0800 (PST) Received: from tw-172-25-17-123.office.twttr.net ([8.25.197.27]) by smtp.gmail.com with ESMTPSA id q1sm24162533pfb.96.2019.01.22.22.41.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Jan 2019 22:41:48 -0800 (PST) From: Cong Wang To: netdev@vger.kernel.org Cc: Cong Wang , Jamal Hadi Salim , Jiri Pirko , David Ahern Subject: [Patch iproute2] tc: add performance counters for basic filter Date: Tue, 22 Jan 2019 22:41:45 -0800 Message-Id: <20190123064145.26169-1-xiyou.wangcong@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Sample output: filter protocol arp pref 49152 basic chain 0 filter protocol arp pref 49152 basic chain 0 handle 0x1 (rule hit 3 success 3) action order 1: gact action pass random type none pass val 0 index 1 ref 1 bind 1 installed 81 sec used 4 sec Action statistics: Sent 126 bytes 3 pkt (dropped 0, overlimits 0 requeues 0) backlog 0b 0p requeues 0 Cc: Jamal Hadi Salim Cc: Jiri Pirko Cc: David Ahern Signed-off-by: Cong Wang --- tc/f_basic.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/tc/f_basic.c b/tc/f_basic.c index af98c088..97d43d49 100644 --- a/tc/f_basic.c +++ b/tc/f_basic.c @@ -110,6 +110,7 @@ static int basic_print_opt(struct filter_util *qu, FILE *f, struct rtattr *opt, __u32 handle) { struct rtattr *tb[TCA_BASIC_MAX+1]; + struct tc_basic_pcnt *pf = NULL; if (opt == NULL) return 0; @@ -125,6 +126,19 @@ static int basic_print_opt(struct filter_util *qu, FILE *f, sprint_tc_classid(rta_getattr_u32(tb[TCA_BASIC_CLASSID]), b1)); } + if (tb[TCA_BASIC_PCNT]) { + if (RTA_PAYLOAD(tb[TCA_BASIC_PCNT]) < sizeof(*pf)) { + fprintf(f, "Broken perf counters\n"); + return -1; + } + pf = RTA_DATA(tb[TCA_BASIC_PCNT]); + } + + if (show_stats && NULL != pf) + fprintf(f, " (rule hit %llu success %llu)", + (unsigned long long) pf->rcnt, + (unsigned long long) pf->rhit); + if (tb[TCA_BASIC_EMATCHES]) print_ematch(f, tb[TCA_BASIC_EMATCHES]); -- 2.20.1