* [PATCH net-next] bna: Mark expected switch fall-throughs
@ 2019-01-23 7:53 Gustavo A. R. Silva
2019-01-23 8:03 ` Sudarsana Reddy Kalluru
2019-01-23 17:07 ` David Miller
0 siblings, 2 replies; 5+ messages in thread
From: Gustavo A. R. Silva @ 2019-01-23 7:53 UTC (permalink / raw)
To: Rasesh Mody, Sudarsana Kalluru, Dept-GELinuxNICDev,
David S. Miller
Cc: netdev, linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
This patch fixes the following warnings:
drivers/net/ethernet/brocade/bna/bfa_ioc.c:790:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
drivers/net/ethernet/brocade/bna/bfa_ioc.c:860:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling
-Wimplicit-fallthrough
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/net/ethernet/brocade/bna/bfa_ioc.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc.c b/drivers/net/ethernet/brocade/bna/bfa_ioc.c
index a36e38676640..cbc9175d74c5 100644
--- a/drivers/net/ethernet/brocade/bna/bfa_ioc.c
+++ b/drivers/net/ethernet/brocade/bna/bfa_ioc.c
@@ -788,9 +788,8 @@ bfa_iocpf_sm_enabling(struct bfa_iocpf *iocpf, enum iocpf_event event)
case IOCPF_E_INITFAIL:
del_timer(&ioc->iocpf_timer);
- /*
- * !!! fall through !!!
- */
+ /* fall through */
+
case IOCPF_E_TIMEOUT:
bfa_nw_ioc_hw_sem_release(ioc);
if (event == IOCPF_E_TIMEOUT)
@@ -858,9 +857,7 @@ bfa_iocpf_sm_disabling(struct bfa_iocpf *iocpf, enum iocpf_event event)
case IOCPF_E_FAIL:
del_timer(&ioc->iocpf_timer);
- /*
- * !!! fall through !!!
- */
+ /* fall through*/
case IOCPF_E_TIMEOUT:
bfa_ioc_set_cur_ioc_fwstate(ioc, BFI_IOC_FAIL);
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [PATCH net-next] bna: Mark expected switch fall-throughs
2019-01-23 7:53 [PATCH net-next] bna: Mark expected switch fall-throughs Gustavo A. R. Silva
@ 2019-01-23 8:03 ` Sudarsana Reddy Kalluru
2019-01-23 8:06 ` Gustavo A. R. Silva
2019-01-23 17:07 ` David Miller
2019-01-23 17:07 ` David Miller
1 sibling, 2 replies; 5+ messages in thread
From: Sudarsana Reddy Kalluru @ 2019-01-23 8:03 UTC (permalink / raw)
To: Gustavo A. R. Silva, Rasesh Mody, Sudarsana Kalluru,
Dept-GELinuxNICDev@cavium.com, David S. Miller
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
-----Original Message-----
From: Gustavo A. R. Silva [mailto:gustavo@embeddedor.com]
Sent: 23 January 2019 13:23
To: Rasesh Mody <rasesh.mody@cavium.com>; Sudarsana Kalluru <sudarsana.kalluru@cavium.com>; Dept-GELinuxNICDev@cavium.com; David S. Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Gustavo A. R. Silva <gustavo@embeddedor.com>
Subject: [PATCH net-next] bna: Mark expected switch fall-throughs
External Email
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
drivers/net/ethernet/brocade/bna/bfa_ioc.c:790:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
drivers/net/ethernet/brocade/bna/bfa_ioc.c:860:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/net/ethernet/brocade/bna/bfa_ioc.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc.c b/drivers/net/ethernet/brocade/bna/bfa_ioc.c
index a36e38676640..cbc9175d74c5 100644
--- a/drivers/net/ethernet/brocade/bna/bfa_ioc.c
+++ b/drivers/net/ethernet/brocade/bna/bfa_ioc.c
@@ -788,9 +788,8 @@ bfa_iocpf_sm_enabling(struct bfa_iocpf *iocpf, enum iocpf_event event)
case IOCPF_E_INITFAIL:
del_timer(&ioc->iocpf_timer);
- /*
- * !!! fall through !!!
- */
+ /* fall through */
+
case IOCPF_E_TIMEOUT:
bfa_nw_ioc_hw_sem_release(ioc);
if (event == IOCPF_E_TIMEOUT) @@ -858,9 +857,7 @@ bfa_iocpf_sm_disabling(struct bfa_iocpf *iocpf, enum iocpf_event event)
case IOCPF_E_FAIL:
del_timer(&ioc->iocpf_timer);
- /*
- * !!! fall through !!!
- */
+ /* fall through*/
case IOCPF_E_TIMEOUT:
bfa_ioc_set_cur_ioc_fwstate(ioc, BFI_IOC_FAIL);
--
2.20.1
Acked-by: Sudarsana Kalluru <Sudarsana.Kalluru@cavium.com>
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH net-next] bna: Mark expected switch fall-throughs
2019-01-23 8:03 ` Sudarsana Reddy Kalluru
@ 2019-01-23 8:06 ` Gustavo A. R. Silva
2019-01-23 17:07 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: Gustavo A. R. Silva @ 2019-01-23 8:06 UTC (permalink / raw)
To: Sudarsana Reddy Kalluru, Rasesh Mody, Sudarsana Kalluru,
Dept-GELinuxNICDev@cavium.com, David S. Miller
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
On 1/23/19 2:03 AM, Sudarsana Reddy Kalluru wrote:
> -----Original Message-----
> From: Gustavo A. R. Silva [mailto:gustavo@embeddedor.com]
> Sent: 23 January 2019 13:23
> To: Rasesh Mody <rasesh.mody@cavium.com>; Sudarsana Kalluru <sudarsana.kalluru@cavium.com>; Dept-GELinuxNICDev@cavium.com; David S. Miller <davem@davemloft.net>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Gustavo A. R. Silva <gustavo@embeddedor.com>
> Subject: [PATCH net-next] bna: Mark expected switch fall-throughs
>
> External Email
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warnings:
>
> drivers/net/ethernet/brocade/bna/bfa_ioc.c:790:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> drivers/net/ethernet/brocade/bna/bfa_ioc.c:860:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/net/ethernet/brocade/bna/bfa_ioc.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc.c b/drivers/net/ethernet/brocade/bna/bfa_ioc.c
> index a36e38676640..cbc9175d74c5 100644
> --- a/drivers/net/ethernet/brocade/bna/bfa_ioc.c
> +++ b/drivers/net/ethernet/brocade/bna/bfa_ioc.c
> @@ -788,9 +788,8 @@ bfa_iocpf_sm_enabling(struct bfa_iocpf *iocpf, enum iocpf_event event)
>
> case IOCPF_E_INITFAIL:
> del_timer(&ioc->iocpf_timer);
> - /*
> - * !!! fall through !!!
> - */
> + /* fall through */
> +
> case IOCPF_E_TIMEOUT:
> bfa_nw_ioc_hw_sem_release(ioc);
> if (event == IOCPF_E_TIMEOUT) @@ -858,9 +857,7 @@ bfa_iocpf_sm_disabling(struct bfa_iocpf *iocpf, enum iocpf_event event)
>
> case IOCPF_E_FAIL:
> del_timer(&ioc->iocpf_timer);
> - /*
> - * !!! fall through !!!
> - */
> + /* fall through*/
>
> case IOCPF_E_TIMEOUT:
> bfa_ioc_set_cur_ioc_fwstate(ioc, BFI_IOC_FAIL);
> --
> 2.20.1
>
> Acked-by: Sudarsana Kalluru <Sudarsana.Kalluru@cavium.com>
>
Thanks, Sudarsana.
--
Gustavo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] bna: Mark expected switch fall-throughs
2019-01-23 8:03 ` Sudarsana Reddy Kalluru
2019-01-23 8:06 ` Gustavo A. R. Silva
@ 2019-01-23 17:07 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: David Miller @ 2019-01-23 17:07 UTC (permalink / raw)
To: skalluru
Cc: gustavo, rasesh.mody, sudarsana.kalluru, Dept-GELinuxNICDev,
netdev, linux-kernel
From: Sudarsana Reddy Kalluru <skalluru@marvell.com>
Date: Wed, 23 Jan 2019 08:03:12 +0000
> -----Original Message-----
> From: Gustavo A. R. Silva [mailto:gustavo@embeddedor.com]
> Sent: 23 January 2019 13:23
> To: Rasesh Mody <rasesh.mody@cavium.com>; Sudarsana Kalluru <sudarsana.kalluru@cavium.com>; Dept-GELinuxNICDev@cavium.com; David S. Miller <davem@davemloft.net>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Gustavo A. R. Silva <gustavo@embeddedor.com>
> Subject: [PATCH net-next] bna: Mark expected switch fall-throughs
>
> External Email
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warnings:
>
> drivers/net/ethernet/brocade/bna/bfa_ioc.c:790:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> drivers/net/ethernet/brocade/bna/bfa_ioc.c:860:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] bna: Mark expected switch fall-throughs
2019-01-23 7:53 [PATCH net-next] bna: Mark expected switch fall-throughs Gustavo A. R. Silva
2019-01-23 8:03 ` Sudarsana Reddy Kalluru
@ 2019-01-23 17:07 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: David Miller @ 2019-01-23 17:07 UTC (permalink / raw)
To: gustavo
Cc: rasesh.mody, sudarsana.kalluru, Dept-GELinuxNICDev, netdev,
linux-kernel
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Date: Wed, 23 Jan 2019 01:53:28 -0600
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> This patch fixes the following warnings:
>
> drivers/net/ethernet/brocade/bna/bfa_ioc.c:790:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> drivers/net/ethernet/brocade/bna/bfa_ioc.c:860:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-23 17:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-23 7:53 [PATCH net-next] bna: Mark expected switch fall-throughs Gustavo A. R. Silva
2019-01-23 8:03 ` Sudarsana Reddy Kalluru
2019-01-23 8:06 ` Gustavo A. R. Silva
2019-01-23 17:07 ` David Miller
2019-01-23 17:07 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).