From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D0F3C282C0 for ; Wed, 23 Jan 2019 08:31:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6CA17217F5 for ; Wed, 23 Jan 2019 08:31:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548232294; bh=35JkuCRBLqzhVCFLw+uVScwMfnilUYp++bCkbZ967qk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=SRsMEuJ+WpFpO0Wj27h58wZ7HMBhy4lajj3PCf81vbyEGQRJt4wA+YJxbkIfVdD8L zLfLApeYPuKE+R2JTN3cfj6iZQhLk40M+olBaUqrbEsns7XVe0Han/FZtFJMHU1tkq eBCI9e9LEnwNKtb+e0Cm299cwxNffTYw86YIDF9Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726942AbfAWIbd (ORCPT ); Wed, 23 Jan 2019 03:31:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:41926 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726191AbfAWIbc (ORCPT ); Wed, 23 Jan 2019 03:31:32 -0500 Received: from localhost (unknown [27.59.118.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E949520870; Wed, 23 Jan 2019 08:31:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548232292; bh=35JkuCRBLqzhVCFLw+uVScwMfnilUYp++bCkbZ967qk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PPMTbnSulY72wEC7QTS0QkY6rJ8iL5GPfxMt3BDc8yAg6hVQPw6IrAkDSuzTaHAFv AeJPwSz904Cv/3xuvFYUAE6mSMTP3ymTFBopS417B+Ful0yEyAmN1pZReZlNXRidOD VKIS9kHVIS6+ic+yuHSnEnIHYp3BiIz5lOp1PzPU= Date: Wed, 23 Jan 2019 14:00:01 +0530 From: Vinod Koul To: Wei Yongjun , davem@davemloft.net Cc: Niklas Cassel , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net-next] net: stmmac: Fix return value check in qcom_ethqos_probe() Message-ID: <20190123083001.GL4635@vkoul-mobl> References: <1548224358-83281-1-git-send-email-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1548224358-83281-1-git-send-email-weiyongjun1@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 23-01-19, 06:19, Wei Yongjun wrote: > In case of error, the function devm_clk_get() returns ERR_PTR() and > never returns NULL. The NULL test in the return value check should be > replaced with IS_ERR(). Acked-by: Vinod Koul This is a networking subsystem patch and you missed Dave :( > Fixes: a7c30e62d4b8 ("net: stmmac: Add driver for Qualcomm ethqos") > Signed-off-by: Wei Yongjun > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > index 30724bd..7ec8954 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > @@ -473,8 +473,8 @@ static int qcom_ethqos_probe(struct platform_device *pdev) > ethqos->por = of_device_get_match_data(&pdev->dev); > > ethqos->rgmii_clk = devm_clk_get(&pdev->dev, "rgmii"); > - if (!ethqos->rgmii_clk) { > - ret = -ENOMEM; > + if (IS_ERR(ethqos->rgmii_clk)) { > + ret = PTR_ERR(ethqos->rgmii_clk); > goto err_mem; > } > > -- ~Vinod