From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F848C282C5 for ; Wed, 23 Jan 2019 09:45:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B6F620861 for ; Wed, 23 Jan 2019 09:45:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="04qPrQUu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727131AbfAWJpK (ORCPT ); Wed, 23 Jan 2019 04:45:10 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:45918 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726291AbfAWJpJ (ORCPT ); Wed, 23 Jan 2019 04:45:09 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id x0N9cws2018603; Wed, 23 Jan 2019 09:45:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type; s=corp-2018-07-02; bh=4OKXC+mHio0hOOfxDbn7LUOuQDZc0fbBSIxNC+rCbLw=; b=04qPrQUunYsITlM5r1uTmhb6Kx3tYUwnzbbpa6nAeAq5nnFAfKDLCtmH0BylGPzw6gYl hHKpfXbdBTDIPjnjzAxY4xYP6quJmGFsVOW5+538n8zO2aFFkws+J3NkTgUdpPA1rc8+ a84HAip8XPDNZ+EJPs8iPPdxVOmO0H4jgITPG65bTNekUqWoPICl1WKiVQCuSCKCXiyO dRt5E3dTqThbYwcQ448gPHDPxiyQ58JxmsGUl4F66hhihaLrSqNwslosiCURm6XjkTMM uGETLEkSIxih34vUXlyyXMrE8uXKv6gC/F9DtvjastQoNPPrHM3ipI8wdA7isIJXDyU3 MA== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp2130.oracle.com with ESMTP id 2q3sdegxps-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Jan 2019 09:45:02 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x0N9j1JA025663 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Jan 2019 09:45:01 GMT Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x0N9j0A8013702; Wed, 23 Jan 2019 09:45:00 GMT Received: from kadam (/197.157.34.164) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 23 Jan 2019 01:44:59 -0800 Date: Wed, 23 Jan 2019 12:44:34 +0300 From: Dan Carpenter To: Jiri Pirko , Eran Ben Elisha Cc: "David S. Miller" , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH net-next] devlink: Use after free in devlink_health_reporter_destroy() Message-ID: <20190123094434.GB26018@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9144 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=781 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901230074 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This calls kfree(reporter); before dereferencing reporter on the next line when it does mutex_unlock(&reporter->devlink->lock); Fixes: 880ee82f0313 ("devlink: Add health reporter create/destroy functionality") Signed-off-by: Dan Carpenter --- net/core/devlink.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/core/devlink.c b/net/core/devlink.c index 60248a53c0ad..deccce13285a 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -4223,14 +4223,16 @@ EXPORT_SYMBOL_GPL(devlink_health_reporter_create); void devlink_health_reporter_destroy(struct devlink_health_reporter *reporter) { - mutex_lock(&reporter->devlink->lock); + struct devlink *devlink = reporter->devlink; + + mutex_lock(&devlink->lock); list_del(&reporter->list); devlink_health_buffers_destroy(reporter->dump_buffers_array, DEVLINK_HEALTH_SIZE_TO_BUFFERS(reporter->ops->dump_size)); devlink_health_buffers_destroy(reporter->diagnose_buffers_array, DEVLINK_HEALTH_SIZE_TO_BUFFERS(reporter->ops->diagnose_size)); kfree(reporter); - mutex_unlock(&reporter->devlink->lock); + mutex_unlock(&devlink->lock); } EXPORT_SYMBOL_GPL(devlink_health_reporter_destroy); -- 2.17.1