From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E94A0C282C0 for ; Wed, 23 Jan 2019 10:39:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B191F20861 for ; Wed, 23 Jan 2019 10:39:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="MBXmFMG/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727115AbfAWKjU (ORCPT ); Wed, 23 Jan 2019 05:39:20 -0500 Received: from mail-lj1-f196.google.com ([209.85.208.196]:38542 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726317AbfAWKjU (ORCPT ); Wed, 23 Jan 2019 05:39:20 -0500 Received: by mail-lj1-f196.google.com with SMTP id c19-v6so1474551lja.5 for ; Wed, 23 Jan 2019 02:39:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=JNpQ+/5iwZyTvORBp3CtrwihaTdurJBDQSvMmysi55Q=; b=MBXmFMG/qdjgPNRoI52FDu9AtF3UzC31yd0HImQHdbkqkRt+niWYOAf1WL4F4l3uko drrOO9C11JLOjK6hhkwV/RuObeyi/sHze3ii8uLcEr1Y/Srt4h90Zw6kYUAVZuROsMDD WN2wEkvqDlt52/7rl1f2jl8n2KPZXDU96f7wU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=JNpQ+/5iwZyTvORBp3CtrwihaTdurJBDQSvMmysi55Q=; b=l8eI+tDzrGJb0c7z5TLBHG7lBGSbmtgFMI65W0AEou5PDMQ/v7YHuSc25fFvGViwr4 IGKnZ2ccptLOiDa4AQ7SUhhitQ33rEe+/+6OyX9cvu5jf4iCcaKIFtkDPPNCtFZDdHHE nU2dggZmQLlgMwzRqxJ0BmgWeb4jUWbhoKDCsRU1FnJLWKnszCoPOWabKkI3QVpaHGAK DyHidI36n424i4yYVM8u4+gpHGVVNDg0oMuXW6k+mOQcCUAtyj48ffd430/i5pjKJ7Hx mvik56/2Qh9l904ejavpDtADJL3pEAYIsifaAtA7Da3O1tb5aF2vbsQfc3//NOI6nJqx p/jw== X-Gm-Message-State: AJcUukcAr5j91lRdPDOvAYp8M8jr7+OqSHgKYtWhXCFAColY4RK5EAvS fq18c2RYDZcT+etWyu1zqrJ2nQ== X-Google-Smtp-Source: ALg8bN4e+TmTMymXuBlMst/uhjKRf2kDvrVOeBslE8bGY+MOrLqFt+SGD3cZHLgb1hvcWmXNr8L9gg== X-Received: by 2002:a2e:8187:: with SMTP id e7-v6mr1446575ljg.67.1548239958143; Wed, 23 Jan 2019 02:39:18 -0800 (PST) Received: from centauri.lan (h-229-118.A785.priv.bahnhof.se. [5.150.229.118]) by smtp.gmail.com with ESMTPSA id o17sm412116lff.77.2019.01.23.02.39.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Jan 2019 02:39:17 -0800 (PST) Date: Wed, 23 Jan 2019 11:39:15 +0100 From: Niklas Cassel To: Wei Yongjun Cc: Vinod Koul , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net-next] net: stmmac: Fix return value check in qcom_ethqos_probe() Message-ID: <20190123103915.GA20558@centauri.lan> References: <1548224358-83281-1-git-send-email-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1548224358-83281-1-git-send-email-weiyongjun1@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jan 23, 2019 at 06:19:18AM +0000, Wei Yongjun wrote: > In case of error, the function devm_clk_get() returns ERR_PTR() and > never returns NULL. The NULL test in the return value check should be > replaced with IS_ERR(). > > Fixes: a7c30e62d4b8 ("net: stmmac: Add driver for Qualcomm ethqos") > Signed-off-by: Wei Yongjun > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > index 30724bd..7ec8954 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > @@ -473,8 +473,8 @@ static int qcom_ethqos_probe(struct platform_device *pdev) > ethqos->por = of_device_get_match_data(&pdev->dev); > > ethqos->rgmii_clk = devm_clk_get(&pdev->dev, "rgmii"); > - if (!ethqos->rgmii_clk) { > - ret = -ENOMEM; > + if (IS_ERR(ethqos->rgmii_clk)) { > + ret = PTR_ERR(ethqos->rgmii_clk); > goto err_mem; > } > > > Acked-by: Niklas Cassel