From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 250D6C282C0 for ; Wed, 23 Jan 2019 11:17:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E34D820870 for ; Wed, 23 Jan 2019 11:17:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="l0L/jeUc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727295AbfAWLRb (ORCPT ); Wed, 23 Jan 2019 06:17:31 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:38429 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726359AbfAWLRa (ORCPT ); Wed, 23 Jan 2019 06:17:30 -0500 Received: by mail-wm1-f68.google.com with SMTP id m22so1572588wml.3 for ; Wed, 23 Jan 2019 03:17:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=FYO53ottzPmpG1fsCezMzPsMD3CKdy3AC+8OeWjP/Uc=; b=l0L/jeUcyqf0C9Bl0b90BKch8yq5zJMUDHHe1CtGgAgSjioruB0/pZ2LnksEFgdakE 8J1b0DVw2D9YMEAkkqR7lsQPgYRWXQDWDfrCkbOHNDZRXxbp8qlY6tkVy2+cHIcyvbXX W4+qUwVu+fFQChIAXmWO1UjOa5TSYqqiUQH/dtsyGRpkExDQhdYsOn8zZexhg5mAdnu1 4loFvAMjIsd1pR7rNYE1DkkLf1l7o7SiCYaYlCA7jNkLV5Iv8RYjA8Ms2QV26M0pjUvh Ga42Jpl41sjEsWQ4b0gabMwgSHvCeCBQOL2E3ugmPZW+VTPTpyRxKU31swauS27HzkVr taFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=FYO53ottzPmpG1fsCezMzPsMD3CKdy3AC+8OeWjP/Uc=; b=Q5zyxyROlX5RprdfSSlT53FHMqzCkmlWTwV/Iyh7G9V0jkuuyX2wDq2/zBIbPrEE3n SAcn8ZHvJ8eyJ7iUXLl8Ozp9TRu1Xb8Im40CV6g/qCzPxpnJH/UllS5QTsGBReubme+1 /uVVzdEOTRVPRR1v/I0ayDKdLdBAhcTCaCqOXQgeFSCbAG+AI+DVk/kFeaw00j7/QAnU c7fQG+bEFJQceFxnQV8RAtzL1k7ICrqqV985uNy2RVBf8SVnBuw0rMhbQS7YlupQWjrf cSgBJ550BChiu1cE37TktvoFEUIEHH4ASQJrr2akij5sqrAUGqWUTh3wMik8wB4DF6pu uVPg== X-Gm-Message-State: AJcUukdVvavTTT+d3DtEwaCkbGu4W4KhqykGcwX9Tm0i7hPkyghwn/Iv Ajftftd+U6lFhA8aIlCv5uUQvw== X-Google-Smtp-Source: ALg8bN516b0r02scu9pk53q86cfUWgLxYk9OlfXcS610U3zgwlreDN+5o/8JsocwRZOs2gB3pgn+bg== X-Received: by 2002:a1c:df46:: with SMTP id w67mr2372854wmg.51.1548242248709; Wed, 23 Jan 2019 03:17:28 -0800 (PST) Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id j33sm160036869wre.91.2019.01.23.03.17.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Jan 2019 03:17:28 -0800 (PST) Date: Wed, 23 Jan 2019 12:08:40 +0100 From: Jiri Pirko To: Vasundhara Volam Cc: davem@davemloft.net, michael.chan@broadcom.com, jiri@mellanox.com, jakub.kicinski@netronome.com, mkubecek@suse.cz, netdev@vger.kernel.org Subject: Re: [PATCH net-next v7 4/8] devlink: Add support for driverinit get value for devlink_port Message-ID: <20190123110839.GD2191@nanopsycho> References: <1547795385-12354-1-git-send-email-vasundhara-v.volam@broadcom.com> <1547795385-12354-5-git-send-email-vasundhara-v.volam@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1547795385-12354-5-git-send-email-vasundhara-v.volam@broadcom.com> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fri, Jan 18, 2019 at 08:09:41AM CET, vasundhara-v.volam@broadcom.com wrote: >Add support for "driverinit" configuration mode value for devlink_port >configuration parameters. Add devlink_port_param_driverinit_value_get() >function to help the driver get the value from devlink_port. > >Also, move the common code to __devlink_param_driverinit_value_get() >to be used by both device and port params. > >Cc: Jiri Pirko >Signed-off-by: Vasundhara Volam >--- > include/net/devlink.h | 8 ++++++ > net/core/devlink.c | 67 ++++++++++++++++++++++++++++++++++++++------------- > 2 files changed, 58 insertions(+), 17 deletions(-) > >diff --git a/include/net/devlink.h b/include/net/devlink.h >index 98b8a66..09f3f43 100644 >--- a/include/net/devlink.h >+++ b/include/net/devlink.h >@@ -838,6 +838,14 @@ static inline bool devlink_dpipe_table_counter_enabled(struct devlink *devlink, > { > } > >+static inline int >+devlink_port_param_driverinit_value_get(struct devlink_port *devlink_port, >+ u32 param_id, >+ union devlink_param_value *init_val) >+{ >+ return -EOPNOTSUPP; >+} You are missing function declaration in case IS_ENABLED(CONFIG_NET_DEVLINK Otherwise this looks fine. >+ > static inline struct devlink_region * > devlink_region_create(struct devlink *devlink, > const char *region_name, [...]