From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62CD4C282C0 for ; Wed, 23 Jan 2019 21:17:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 393AB2184C for ; Wed, 23 Jan 2019 21:17:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726694AbfAWVRp (ORCPT ); Wed, 23 Jan 2019 16:17:45 -0500 Received: from Chamillionaire.breakpoint.cc ([146.0.238.67]:58036 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726340AbfAWVRo (ORCPT ); Wed, 23 Jan 2019 16:17:44 -0500 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.89) (envelope-from ) id 1gmPu3-0002Oh-1G; Wed, 23 Jan 2019 22:17:43 +0100 Date: Wed, 23 Jan 2019 22:17:43 +0100 From: Florian Westphal To: Cong Wang Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, syzbot+fcee88b2d87f0539dfe9@syzkaller.appspotmail.com, Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal Subject: Re: [Patch nf-next] nf_conntrack: fix error path in nf_conntrack_pernet_init() Message-ID: <20190123211743.dvbkizgxm3ohwkcs@breakpoint.cc> References: <20190123205857.8107-1-xiyou.wangcong@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190123205857.8107-1-xiyou.wangcong@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Cong Wang wrote: > When nf_ct_netns_get() fails, it should clean up itself, > its caller doesn't need to call nf_conntrack_fini_net(). Thanks a lot for fixing this!