From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03BD3C282C5 for ; Fri, 25 Jan 2019 02:25:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D1367218D0 for ; Fri, 25 Jan 2019 02:25:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728574AbfAYCZM (ORCPT ); Thu, 24 Jan 2019 21:25:12 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:36804 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728199AbfAYCZM (ORCPT ); Thu, 24 Jan 2019 21:25:12 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 9CC1B10888E7E; Thu, 24 Jan 2019 18:25:11 -0800 (PST) Date: Thu, 24 Jan 2019 18:25:06 -0800 (PST) Message-Id: <20190124.182506.271204705053172488.davem@davemloft.net> To: lucien.xin@gmail.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-sctp@vger.kernel.org, marcelo.leitner@gmail.com, nhorman@tuxdriver.com Subject: Re: [PATCH net] sctp: improve the events for sctp stream reset From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 24 Jan 2019 18:25:11 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Xin Long Date: Tue, 22 Jan 2019 02:39:34 +0800 > This patch is to improve sctp stream reset events in 4 places: > > 1. In sctp_process_strreset_outreq(), the flag should always be set with > SCTP_STREAM_RESET_INCOMING_SSN instead of OUTGOING, as receiver's in > stream is reset here. > 2. In sctp_process_strreset_outreq(), move up SCTP_STRRESET_ERR_WRONG_SSN > check, as the reset has to succeed after reconf_timer stops for the > in stream reset request retransmission. > 3. In sctp_process_strreset_inreq(), no event should be sent, as no in > or out stream is reset here. > 4. In sctp_process_strreset_resp(), SCTP_STREAM_RESET_INCOMING_SSN or > OUTGOING event should always be sent for stream reset requests, no > matter it fails or succeeds to process the request. > > Fixes: 810544764536 ("sctp: implement receiver-side procedures for the Outgoing SSN Reset Request Parameter") > Fixes: 16e1a91965b0 ("sctp: implement receiver-side procedures for the Incoming SSN Reset Request Parameter") > Fixes: 11ae76e67a17 ("sctp: implement receiver-side procedures for the Reconf Response Parameter") > Reported-by: Ying Xu > Signed-off-by: Xin Long Applied and queued up for -stable.