From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C539C282C3 for ; Fri, 25 Jan 2019 02:25:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 03AC3218CD for ; Fri, 25 Jan 2019 02:25:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728656AbfAYCZd (ORCPT ); Thu, 24 Jan 2019 21:25:33 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:36830 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728625AbfAYCZd (ORCPT ); Thu, 24 Jan 2019 21:25:33 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 75AE110888E80; Thu, 24 Jan 2019 18:25:32 -0800 (PST) Date: Thu, 24 Jan 2019 18:25:32 -0800 (PST) Message-Id: <20190124.182532.1983690003554983866.davem@davemloft.net> To: lucien.xin@gmail.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-sctp@vger.kernel.org, marcelo.leitner@gmail.com, nhorman@tuxdriver.com Subject: Re: [PATCH net] sctp: set chunk transport correctly when it's a new asoc From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 24 Jan 2019 18:25:32 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Xin Long Date: Tue, 22 Jan 2019 02:42:09 +0800 > In the paths: > > sctp_sf_do_unexpected_init() -> > sctp_make_init_ack() > sctp_sf_do_dupcook_a/b()() -> > sctp_sf_do_5_1D_ce() > > The new chunk 'retval' transport is set from the incoming chunk 'chunk' > transport. However, 'retval' transport belong to the new asoc, which > is a different one from 'chunk' transport's asoc. > > It will cause that the 'retval' chunk gets set with a wrong transport. > Later when sending it and because of Commit b9fd683982c9 ("sctp: add > sctp_packet_singleton"), sctp_packet_singleton() will set some fields, > like vtag to 'retval' chunk from that wrong transport's asoc. > > This patch is to fix it by setting 'retval' transport correctly which > belongs to the right asoc in sctp_make_init_ack() and > sctp_sf_do_5_1D_ce(). > > Fixes: b9fd683982c9 ("sctp: add sctp_packet_singleton") > Reported-by: Ying Xu > Signed-off-by: Xin Long Applied and queued up for -stable.