From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD059C282C2 for ; Fri, 25 Jan 2019 06:26:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 85EBF218D9 for ; Fri, 25 Jan 2019 06:26:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727507AbfAYG0e (ORCPT ); Fri, 25 Jan 2019 01:26:34 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:38232 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726021AbfAYG0e (ORCPT ); Fri, 25 Jan 2019 01:26:34 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C03F11444BA3E; Thu, 24 Jan 2019 22:26:33 -0800 (PST) Date: Thu, 24 Jan 2019 22:26:33 -0800 (PST) Message-Id: <20190124.222633.2060668722604229381.davem@davemloft.net> To: hkallweit1@gmail.com Cc: nic_swsd@realtek.com, netdev@vger.kernel.org Subject: Re: [PATCH net-next] r8169: factor out PHY init sequence adjusting 10M and ALDPS From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 24 Jan 2019 22:26:33 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Heiner Kallweit Date: Wed, 23 Jan 2019 20:47:30 +0100 > Few chip versions use the same sequence to adjust 10M and ALDPS, so > let's factor it out. This patch also fixes a (most likely) typo in > rtl8168g_1_hw_phy_config. There bit 8 in reg 0x14 on page 0x0bcc > was set and not cleared. According to the vendor driver this bit > needs to be cleared in all cases. > > Signed-off-by: Heiner Kallweit Applied.