From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A294C282C0 for ; Fri, 25 Jan 2019 06:27:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 14B24218D2 for ; Fri, 25 Jan 2019 06:27:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726845AbfAYG1o (ORCPT ); Fri, 25 Jan 2019 01:27:44 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:38244 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726021AbfAYG1o (ORCPT ); Fri, 25 Jan 2019 01:27:44 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 447ED1449B3AC; Thu, 24 Jan 2019 22:27:44 -0800 (PST) Date: Thu, 24 Jan 2019 22:27:43 -0800 (PST) Message-Id: <20190124.222743.64593079002945909.davem@davemloft.net> To: priyarjha@google.com Cc: netdev@vger.kernel.org Subject: Re: [PATCH net-next 0/2] tcp_bbr: Improving TCP BBR performance for WiFi and cellular networks From: David Miller In-Reply-To: <20190123200454.260121-1-priyarjha@google.com> References: <20190123200454.260121-1-priyarjha@google.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 24 Jan 2019 22:27:44 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Priyaranjan Jha Date: Wed, 23 Jan 2019 12:04:52 -0800 > Ack aggregation is quite prevalent with wifi, cellular and cable modem > link tchnologies, ACK decimation in middleboxes, and common offloading > techniques such as TSO and GRO, at end hosts. Previously, BBR was often > cwnd-limited in the presence of severe ACK aggregation, which resulted in > low throughput due to insufficient data in flight. > > To achieve good throughput for wifi and other paths with aggregation, this > patch series implements an ACK aggregation estimator for BBR, which > estimates the maximum recent degree of ACK aggregation and adapts cwnd > based on it. The algorithm is further described by the following > presentation: > https://datatracker.ietf.org/meeting/101/materials/slides-101-iccrg-an-update-on-bbr-work-at-google-00 > > (1) A preparatory patch, which refactors bbr_target_cwnd for generic > inflight provisioning. > > (2) Implements BBR ack aggregation estimator and adapts cwnd based > on measured degree of ACK aggregation. Looks great. Series applied, thanks!