From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4927C282C0 for ; Wed, 23 Jan 2019 20:43:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8BC2421872 for ; Wed, 23 Jan 2019 20:43:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="N/whXHXn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726840AbfAWUnm (ORCPT ); Wed, 23 Jan 2019 15:43:42 -0500 Received: from mail-pl1-f178.google.com ([209.85.214.178]:38229 "EHLO mail-pl1-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726803AbfAWUnm (ORCPT ); Wed, 23 Jan 2019 15:43:42 -0500 Received: by mail-pl1-f178.google.com with SMTP id e5so1752375plb.5 for ; Wed, 23 Jan 2019 12:43:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=31NjA5MVmE+z0C1C4ynZSmr7/kbupOAW2QWEvHpVumQ=; b=N/whXHXn7oyNG5GR+0L92yB/hb4jUQC1vi524XUzsoT7m7sgeP8w7FrqATqvcGVPRW 2OkqbJxrK3zV/4eOzw04aGOtLJ/t9p3IskIGSECToagzcdVLqiX6WiVo4jonVC7Ju1De tFrJpXO/U8VHP9Ku4WBlLuj+z7f5fLdNtgbd6NsYWRMKVTS8/JxLoidfd7C5UtIwJrzp VqqfCvFVHwoYH4ZfOxBlCfUcuET6/T68Dz8MAn/WKvTrT/m6ef8MrpKkNvkwO2PUXNrs AWcISCumj7MnIwSMwQ5ZOl4dz+j0T2rnlg4opq09ecQHEirfr54WThBcBBKOdCxnB7UD jj4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=31NjA5MVmE+z0C1C4ynZSmr7/kbupOAW2QWEvHpVumQ=; b=R+r/n4QlXSvRMu35AZXEdBrssVE5hq0f8Re/IrEDuIYVADjFJDCQjyAjiNTR9xerVT O8H6HsBwEoyVxq6ouQIsO+XGNycdTJ9B3T5tlGSQNvqjYBRBuVSsI2twa8koXpwJRZ9m qOc9/NCgSyEAVqIQEpeXr4U3smb74SJnX1z46VsAsJq0z//18hEs6OKA2KjGBNrP1UA+ T7d4RuIFXqFRJJ0GIw8fqNXPwoi3ukFwmBFj6Q367HGiqFc9oMX7aCuJp5IOba5KcZuM ytRMeI53rp60YnFHYf6d3VsNsikSUeprUbn9lCwqtvm1PmEcPqMBCXNeVfUDZUS6cPnL T8XA== X-Gm-Message-State: AJcUukdLY4/x6/k7TUELMzFyNnEfOwwNJC1Eiy5OoD3GlnIu5cBBfWL3 G6mrhK2Vu7dNrS1UDBX92tPjfA== X-Google-Smtp-Source: ALg8bN7plyRmEfxt+Iio5cc5Waw/zBmRp3rwuytb5wnA6Td6Yec1zVyfIPq8jCB9tyjQMzceP6yukg== X-Received: by 2002:a17:902:7b91:: with SMTP id w17mr3778729pll.111.1548276221617; Wed, 23 Jan 2019 12:43:41 -0800 (PST) Received: from shemminger-XPS-13-9360 ([202.36.179.100]) by smtp.gmail.com with ESMTPSA id h19sm24987146pfn.114.2019.01.23.12.43.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Jan 2019 12:43:41 -0800 (PST) Date: Thu, 24 Jan 2019 09:43:32 +1300 From: Stephen Hemminger To: Cong Wang Cc: netdev@vger.kernel.org, Jamal Hadi Salim , Jiri Pirko , David Ahern Subject: Re: [Patch iproute2] tc: add performance counters for basic filter Message-ID: <20190124094332.33d5c67a@shemminger-XPS-13-9360> In-Reply-To: <20190123064145.26169-1-xiyou.wangcong@gmail.com> References: <20190123064145.26169-1-xiyou.wangcong@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 22 Jan 2019 22:41:45 -0800 Cong Wang wrote: > + if (tb[TCA_BASIC_PCNT]) { > + if (RTA_PAYLOAD(tb[TCA_BASIC_PCNT]) < sizeof(*pf)) { > + fprintf(f, "Broken perf counters\n"); > + return -1; Errors should go to stderr not f (which is stdout).